FreeCAD master CI

[PD][TNP][WIP] Use pre-TNP-fix method to revolve up-to-face #177

Annotations

1 error and 30 warnings

Process completed with exit code 1.

src/Mod/PartDesign/App/FeatureRevolution.cpp#L43

Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]

src/Mod/PartDesign/App/FeatureRevolution.cpp#L51

Lines should be <= 120 characters long [whitespace/line_length] [2]

src/Mod/PartDesign/App/FeatureRevolution.cpp#L54

{ should almost always be at the end of the previous line [whitespace/braces] [4]

src/Mod/PartDesign/App/FeatureRevolution.cpp#L59

Missing space after , [whitespace/comma] [3]

src/Mod/PartDesign/App/FeatureRevolution.cpp#L60

Missing space after , [whitespace/comma] [3]

src/Mod/PartDesign/App/FeatureRevolution.cpp#L61

Missing space after , [whitespace/comma] [3]

src/Mod/PartDesign/App/FeatureRevolution.cpp#L66

Missing space after , [whitespace/comma] [3]

src/Mod/PartDesign/App/FeatureRevolution.cpp#L69

Use int16/int64/etc, rather than the C type short [runtime/int] [4]

src/Mod/PartDesign/App/FeatureRevolution.cpp#L70

{ should almost always be at the end of the previous line [whitespace/braces] [4]

src/Mod/PartDesign/App/FeatureRevolution.cpp#L83

{ should almost always be at the end of the previous line [whitespace/braces] [4]

NCollection_ListNode has copy-ctor, copy-assignment but not dtor [-Wclazy-rule-of-three]

Pass small and trivially-copyable type by value (const class NCollection_BaseList::Iterator &) [-Wclazy-function-args-by-value]

Pass small and trivially-copyable type by value (const class gp_XY &) [-Wclazy-function-args-by-value]

src/Mod/PartDesign/App/FeatureRevolution.cpp#L47

do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays]

src/Mod/PartDesign/App/FeatureRevolution.cpp#L58

do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]

src/Mod/PartDesign/App/FeatureRevolution.cpp#L61

360.0 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]

src/Mod/PartDesign/App/FeatureRevolution.cpp#L63

60.0 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]

src/Mod/PartDesign/App/FeatureRevolution.cpp#L77

statement should be inside braces [readability-braces-around-statements]

src/Mod/PartDesign/App/FeatureRevolution.cpp#L82

function 'execute' has cognitive complexity of 29 (threshold 25) [readability-function-cognitive-complexity]

note: +1, including nesting penalty of 0, nesting level increased to 1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PD][TNP][WIP] Use pre-TNP-fix method to revolve up-to-face #177

Lint / Lint

[PD][TNP][WIP] Use pre-TNP-fix method to revolve up-to-face #177

Jobs

Run details

Annotations

This job succeeded

Re-running jobs...