Re-reaise IncompleteReadError as MaybeRecoverableError #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S3 and Azure can throw IncompleteReadError when the TCP session was disrupted. However, current implementation does not re-reaise it as MaybeRecoverableError. As a result, programs like pghoard will give up basebackup download. This is more likely to affect large (2~4 TiB) databases, because large database takes longer to download base backup and more likely to encounter at least one IncompleteReadError. This commit re-reaise IncompleteReadError as MaybeRecoverableError, so pghoard can retry on an object without starting over.
orange-kao
force-pushed
the
orange-incomplete-read-error
branch
from
cbb8dcf to
95c329e
Compare
|
I have force-pushed the branch after fixing for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
S3 and Azure can throw IncompleteReadError when the TCP session was disrupted. However, current implementation does not re-reaise it as MaybeRecoverableError. As a result, programs like pghoard will give up basebackup download.
This is more likely to affect large (2~4 TiB) databases, because large database takes longer to download base backup and more likely to encounter at least one IncompleteReadError.
This commit re-reaise IncompleteReadError as MaybeRecoverableError, so pghoard can retry on an object without starting over.
Why this way
I learned that pghoard use
MaybeRecoverableErrorto decide whether it will retry or not. So I thought re-reaise IncompleteReadError as MaybeRecoverableError might be an option.