Use S3 dualstack endpoint by default #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikonen
reviewed
Mar 26, 2024
rohmu/object_storage/s3.py
Outdated
| @@ -137,6 +137,7 @@ def __init__( | |||
| if proxy_info: | |||
| proxy_url = get_proxy_url(proxy_info) | |||
| custom_config["proxies"] = {"https": proxy_url} | |||
| custom_config["use_dualstack_endpoint"] = True | |||
There was a problem hiding this comment.
Should this be provided as a parameter so that calling code is able to control the value in case this ends up causing some problems?
There was a problem hiding this comment.
I added a configuration option to turn this off, but I'd personally prefer keeping it enabled by default: IPv6 is nowdays well supported, if available and configured.
There was a problem hiding this comment.
That actually reminds me, was this validated against non-AWS implementations of S3? I at least have no idea what's the state of IPv6 with those.
There was a problem hiding this comment.
The config only applies to default botocore addresses, and is not used if one passes explicit host/port information.
When using the default S3 endpoints, request using dualstack IPv4/IPv6 endpoints by default. This behavior can be disabled by configuring S3 with use_dualstack_endpoints as false.
hnousiainen
force-pushed
the
htn_s3_dualstack_endpoints
branch
from
dc1304c to
451b588
Compare
hnousiainen
changed the title
rikonen
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the default S3 endpoints, request using dualstack IPv4/IPv6 endpoints.
About this change - What it does
Configure botocore to utilize dualstack IPv4/IPv6 endpoint for S3. This enables IPv6 only clients to use S3 through rohmu as well.