Accept preloaded RSA keys in encryptor/rohmufile #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading a key can be very slow, especially since OpenSSL 3.0 started validating the keys: pyca/cryptography#7236 Even when using the `unsafe_skip_rsa_key_validation` flag, repeatedly loading the keys for each downloaded or uploaded file still takes unnecessary time. Extend the allowed input types to accept already loaded private and public keys, and also allow these types in the key lookup callback of the `rohmufile` helpers. Even though the key format is not always `pem` anymore, I kept the original parameter name to avoid backward compatibility issues.
kmichel-aiven
force-pushed
the
kmichel-preloaded-keys
branch
from
d1e89b5 to
2805cc7
Compare
Khatskevich
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading a key can be very slow, especially since OpenSSL 3.0 started validating the keys:
pyca/cryptography#7236
Even when using the
unsafe_skip_rsa_key_validationflag, repeatedly loading the keys for each downloaded or uploaded file still takes unnecessary time.Extend the allowed input types to accept already loaded private and public keys, and also allow these types in the key lookup callback of the
rohmufilehelpers.Even though the key format is not always
pemanymore, I kept the original parameter name to avoid backward compatibility issues.About this change - What it does
Resolves: #xxxxx
Why this way