Better retry for base backup restore #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giacomo-alzetta-aiven
requested changes
Oct 28, 2024
orange-kao
force-pushed
the
orange-retry-based-on-backup-size
branch
3 times, most recently
from
dcbc4d6 to
0685c9c
Compare
Current implementation use fixed retry (6) for base backup restore. However, on a large (2~4 TiB) database, there are more data to be transferred and will take longer. As a result, it is more likely to hit the limit. This commit allows a dynamic number of retry, depends on the size of the base backup.
orange-kao
force-pushed
the
orange-retry-based-on-backup-size
branch
from
0685c9c to
4869d84
Compare
|
I have force-pushed to fix However, test failed on While running tests locally |
|
Test passed, ready for review. |
alexole
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Current implementation use fixed retry (6) for base backup restore. However, on a large (2~4 TiB) database, there are more data to be transferred and will take longer. As a result, it is more likely to hit the limit.
This commit allows a dynamic number of retry, depends on the size of the base backup.
Why this way
This seems to be the minimum change to avoid starting over base backup download when restoring a large database. I acknowledge that there are other and/or better ways to implement this.