Add progress based basebackup metrics #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebinsunny
force-pushed
the
sebinsunny-refactor-pg-backup-metrics
branch
3 times, most recently
from
cf6b3ef to
c46ee6a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #615 +/- ##
==========================================
- Coverage 91.10% 90.95% -0.16%
==========================================
Files 32 32
Lines 4823 4918 +95
==========================================
+ Hits 4394 4473 +79
- Misses 429 445 +16
|
rikonen
previously requested changes
Feb 7, 2024
sebinsunny
force-pushed
the
sebinsunny-refactor-pg-backup-metrics
branch
4 times, most recently
from
2348ff0 to
cbc096b
Compare
sebinsunny
force-pushed
the
sebinsunny-refactor-pg-backup-metrics
branch
6 times, most recently
from
68ef95e to
d868541
Compare
RommelLayco
previously requested changes
Feb 9, 2024
sebinsunny
force-pushed
the
sebinsunny-refactor-pg-backup-metrics
branch
3 times, most recently
from
afe89ac to
7e84361
Compare
sebinsunny
force-pushed
the
sebinsunny-refactor-pg-backup-metrics
branch
2 times, most recently
from
11c6a5a to
c2f61c5
Compare
RommelLayco
requested changes
Feb 14, 2024
sebinsunny
force-pushed
the
sebinsunny-refactor-pg-backup-metrics
branch
2 times, most recently
from
e44c744 to
bd1d7d6
Compare
alexole
reviewed
Feb 21, 2024
sebinsunny
force-pushed
the
sebinsunny-refactor-pg-backup-metrics
branch
2 times, most recently
from
175290b to
d76b15e
Compare
facetoe
reviewed
Feb 25, 2024
facetoe
reviewed
Mar 10, 2024
facetoe
reviewed
Mar 10, 2024
sebinsunny
force-pushed
the
sebinsunny-refactor-pg-backup-metrics
branch
2 times, most recently
from
d1b36de to
83b5931
Compare
facetoe
reviewed
Mar 13, 2024
pghoard/basebackup/delta.py
Outdated
| snapshotter.snapshot(reuse_old_snapshotfiles=False) | ||
| def progress_callback(msg: ProgressStep, progress_data: ProgressMetrics): | ||
| key = "snapshot_progress" | ||
| persisted_progress = PersistedProgress.read(self.metrics) |
There was a problem hiding this comment.
This is going to cause a lot of read/writes. We should implement something that mostly updates in memory and writes every now and again as this callback is called a lot AFAIK.
There was a problem hiding this comment.
will update this
facetoe
reviewed
Mar 14, 2024
sebinsunny
force-pushed
the
sebinsunny-refactor-pg-backup-metrics
branch
4 times, most recently
from
e386c66 to
5a186f5
Compare
facetoe
reviewed
Mar 18, 2024
…gularly checks how much data has been uploaded and compares this to the last recorded amount in a persisted progress file. If the upload is progressing, it updates the record with the new data and current time. If the backup has not advanced compared to the previous value, it reports the time elapsed since the last progress and emits stalled metrics. Once a backup is complete, the record is reset. [SRE-7631]
sebinsunny
force-pushed
the
sebinsunny-refactor-pg-backup-metrics
branch
from
5a186f5 to
6e00a1c
Compare
facetoe
approved these changes
Mar 18, 2024
sebinsunny
added a commit
that referenced
this pull request
May 31, 2024
…reviously, we reset the basebackup progress file whenever a new basebackup request was made, which resulted in not catching a few cases where pghoard restarts. Now, the progress file is only reset when a backup is successful, and we also record the total bytes uploaded in the file for the previous basebackup. If there is a retry due to a pghoard restart or a failed backup request, we check if progress has been made; if it has not exceeded the bytes uploaded in the previous state, we emit a stalled metric. Also, added logging for upload progress for each file and snapshot stages in a basebackup operation. [SRE-7476]
sebinsunny
added a commit
that referenced
this pull request
May 31, 2024
…reviously, we reset the basebackup progress file whenever a new basebackup request was made, which resulted in not catching a few cases where pghoard restarts. Now, the progress file is only reset when a backup is successful, and we also record the total bytes uploaded in the file for the previous basebackup. If there is a retry due to a pghoard restart or a failed backup request, we check if progress has been made; if it has not exceeded the bytes uploaded in the previous state, we emit a stalled metric. Also, added logging for upload progress for each file and snapshot stages in a basebackup operation. [SRE-7476]
sebinsunny
added a commit
that referenced
this pull request
May 31, 2024
…reviously, we reset the basebackup progress file whenever a new basebackup request was made, which resulted in not catching a few cases where pghoard restarts. Now, the progress file is only reset when a backup is successful, and we also record the total bytes uploaded in the file for the previous basebackup. If there is a retry due to a pghoard restart or a failed backup request, we check if progress has been made; if it has not exceeded the bytes uploaded in the previous state, we emit a stalled metric. Also, added logging for upload progress for each file and snapshot stages in a basebackup operation. [SRE-7476]
sebinsunny
added a commit
that referenced
this pull request
May 31, 2024
…reviously, we reset the basebackup progress file whenever a new basebackup request was made, which resulted in not catching a few cases where pghoard restarts. Now, the progress file is only reset when a backup is successful, and we also record the total bytes uploaded in the file for the previous basebackup. If there is a retry due to a pghoard restart or a failed backup request, we check if progress has been made; if it has not exceeded the bytes uploaded in the previous state, we emit a stalled metric. Also, added logging for upload progress for each file and snapshot stages in a basebackup operation. [SRE-7476]
sebinsunny
added a commit
that referenced
this pull request
Jun 5, 2024
…reviously, we reset the basebackup progress file whenever a new basebackup request was made, which resulted in not catching a few cases where pghoard restarts. Now, the progress file is only reset when a backup is successful, and we also record the total bytes uploaded in the file for the previous basebackup. If there is a retry due to a pghoard restart or a failed backup request, we check if progress has been made; if it has not exceeded the bytes uploaded in the previous state, we emit a stalled metric. Also, added logging for upload progress for each file and snapshot stages in a basebackup operation. [SRE-7476]
sebinsunny
added a commit
that referenced
this pull request
Jun 5, 2024
…reviously, we reset the basebackup progress file whenever a new basebackup request was made, which resulted in not catching a few cases where pghoard restarts. Now, the progress file is only reset when a backup is successful, and we also record the total bytes uploaded in the file for the previous basebackup. If there is a retry due to a pghoard restart or a failed backup request, we check if progress has been made; if it has not exceeded the bytes uploaded in the previous state, we emit a stalled metric. Also, added logging for upload progress for each file and snapshot stages in a basebackup operation. [SRE-7476]
sebinsunny
added a commit
that referenced
this pull request
Jun 7, 2024
…reviously, we reset the basebackup progress file whenever a new basebackup request was made, which resulted in not catching a few cases where pghoard restarts. Now, the progress file is only reset when a backup is successful, and we also record the total bytes uploaded in the file for the previous basebackup. If there is a retry due to a pghoard restart or a failed backup request, we check if progress has been made; if it has not exceeded the bytes uploaded in the previous state, we emit a stalled metric. Also, added logging for upload progress for each file and snapshot stages in a basebackup operation. [SRE-7476]
sebinsunny
added a commit
that referenced
this pull request
Jun 7, 2024
…reviously, we reset the basebackup progress file whenever a new basebackup request was made, which resulted in not catching a few cases where pghoard restarts. Now, the progress file is only reset when a backup is successful, and we also record the total bytes uploaded in the file for the previous basebackup. If there is a retry due to a pghoard restart or a failed backup request, we check if progress has been made; if it has not exceeded the bytes uploaded in the previous state, we emit a stalled metric. Also, added logging for upload progress for each file and snapshot stages in a basebackup operation. [SRE-7476]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the monitoring of pg basebackups. During a backup, it regularly checks how much data has been uploaded and compares this to the last recorded amount in a persisted progress file. If the upload is progressing, it updates the record with the new data and current time. If the backup has not advanced compared to the previous value, it reports the time elapsed since the last progress and emits stalled metrics. Once a backup is complete, the record is reset.
[SRE-7631]