-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Valid the input path from header 'x-pghoard-target-path' #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xlianhu
force-pushed
the
0xlianhu-BF-2344-security-validate-input-path
branch
6 times, most recently
from
December 7, 2023 15:50
3480d77
to
f744e5c
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #608 +/- ##
==========================================
- Coverage 91.33% 91.14% -0.20%
==========================================
Files 32 32
Lines 4731 4730 -1
==========================================
- Hits 4321 4311 -10
- Misses 410 419 +9
|
0xlianhu
force-pushed
the
0xlianhu-BF-2344-security-validate-input-path
branch
from
December 7, 2023 16:36
f744e5c
to
b3f6cfc
Compare
rdunklau
reviewed
Dec 11, 2023
rdunklau
reviewed
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions about the validation of paths.
0xlianhu
force-pushed
the
0xlianhu-BF-2344-security-validate-input-path
branch
from
December 11, 2023 14:46
b3f6cfc
to
132c716
Compare
0xlianhu
force-pushed
the
0xlianhu-BF-2344-security-validate-input-path
branch
from
December 12, 2023 08:48
132c716
to
3fbc406
Compare
0xlianhu
force-pushed
the
0xlianhu-BF-2344-security-validate-input-path
branch
from
December 12, 2023 09:32
3fbc406
to
0e9ddce
Compare
0xlianhu
force-pushed
the
0xlianhu-BF-2344-security-validate-input-path
branch
from
December 12, 2023 09:35
0e9ddce
to
e21dcaa
Compare
rdunklau
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Security: validate input target path from HTTP header
x-pghoard-target-path