add content-length even if file size is 0 #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kathia-barahona
commented
Nov 28, 2023
kathia-barahona
force-pushed
the
kathiabarahona/uploading_empty_file
branch
from
2aae069 to
23ed525
Compare
rdunklau
approved these changes
Nov 28, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #607 +/- ##
==========================================
- Coverage 91.33% 91.20% -0.13%
==========================================
Files 32 32
Lines 4731 4731
==========================================
- Hits 4321 4315 -6
- Misses 410 416 +6
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
pghoard is not adding content-length when file size is 0, currently rohmu will by default try multipart upload for null content-length file objects.
Resolves: #BF-2330