upload event tracker #604
Closed
upload event tracker #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kathia-barahona
commented
Oct 4, 2023
Comment on lines
+119
to
+121
| # UploadEvents without file_size are allowed, therefore we cannot determine if the event is completed | ||
| if not self.file_size: | ||
| return False |
There was a problem hiding this comment.
question Not sure why do we allow this though
kathia-barahona
commented
Oct 4, 2023
Comment on lines
+167
to
+168
| if file_key not in self._tracked_events: | ||
| raise Exception(f"UploadEvent for {file_key} is not being tracked.") |
There was a problem hiding this comment.
comment probably need to raise something like UntrackedUploadEventError, otherwise this will stop the thread
kathia-barahona
commented
Oct 4, 2023
| if last_increment_at and (now - last_increment_at) >= avg_rate + self.WARNING_TIMEOUT: | ||
| self.log.warning( | ||
| "Upload for file %s has been inactive since %s seconds.", | ||
| ue_progress.file_size, |
There was a problem hiding this comment.
comment oops should be ue_progress.key instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Keeps progress of UploadEvents, in case a file gets stuck it should raise a warning
Resolves: #xxxxx
Why this way