-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test cases to test rohmu's handling zero size file #603
Conversation
d8e9c76
to
0b6f90d
Compare
Codecov Report
@@ Coverage Diff @@
## main #603 +/- ##
==========================================
- Coverage 91.30% 91.28% -0.03%
==========================================
Files 32 32
Lines 4727 4727
==========================================
- Hits 4316 4315 -1
- Misses 411 412 +1 |
0b6f90d
to
b3dc8a8
Compare
b3dc8a8
to
d12aef7
Compare
d66573c
to
43011c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the comments in thread.
Also, there are places that also apply but I didn't want to repeat the same comment in several places :).
77847f2
to
959588e
Compare
Thank you very much for your valuable comments. The file was updated according to your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good, @0xlianhu !
It seems you missed some of the previous comments (had to click on "expand"). I'll let you read them. The PR is good as it is already. Ping me if you want me to merge it as-is. Otherwise, that gives you some time to re-read.
959588e
to
a6389e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's looking great! Less lines = usually a good thing :-).
a6389e3
to
968306b
Compare
968306b
to
0ceffa2
Compare
0ceffa2
to
4952b35
Compare
4952b35
to
b7a4c9a
Compare
The new test doesn't seem to include anything besides rohmu, so it's probably better suited to be in that code base? |
Moving the PR to Rohmu repo instead as @packi suggested. |
Add test cases to test
Rohmu
handle zero size files:Generate an empty file -> compress(lzma/zstd/snappy) and encrypt -> upload (local file system) -> download, decrypt+decompress -> Verify if download files are expected files
Moved this test case to Rohmu instead.
Aiven-Open/rohmu#156