Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump typing_extensions to 4.7.1 #601

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

Aiqin-Aiven
Copy link
Contributor

@Aiqin-Aiven Aiqin-Aiven commented Sep 26, 2023

bump typing_extensions to 4.7.1 as pipeline is broken for rohmu dependency

Why this way

As suggested here:
Aiven-Open/rohmu#144

@codecov-commenter
Copy link

Codecov Report

Merging #601 (f1e4459) into main (60d6bf6) will increase coverage by 0.08%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #601      +/-   ##
==========================================
+ Coverage   91.29%   91.37%   +0.08%     
==========================================
  Files          32       32              
  Lines        4709     4709              
==========================================
+ Hits         4299     4303       +4     
+ Misses        410      406       -4     

see 1 file with indirect coverage changes

Copy link
Contributor

@rominf rominf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would omit for pghoard in commit message, PR title and message, since it's extra (it's pghoard repository 😄), but it is not a blocker of course.

@Aiqin-Aiven Aiqin-Aiven changed the title bump typing_extensions to 4.7.1 for pghoard bump typing_extensions to 4.7.1 Sep 26, 2023
@Aiqin-Aiven
Copy link
Contributor Author

@rominf can you merge it? thanks.

Copy link
Contributor

@Mulugruntz Mulugruntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@Mulugruntz Mulugruntz merged commit 6e6c70b into main Sep 28, 2023
7 checks passed
@Mulugruntz Mulugruntz deleted the aiqin-bump-typing_extension branch September 28, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants