Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding AWS SigV4 authentication #240

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fabiojmendes
Copy link

This pull request implements the AWS SigV4 as described in #197

@willyborankin willyborankin requested a review from reta November 7, 2023 21:28
@reta
Copy link
Contributor

reta commented Nov 7, 2023

@fabiojmendes I believe we do not intent to bundle vendor specific schemes into the connector but offer the capability to have it packaged / bundled with additional JARs that could be loaded using ServiceLoader mechanism, @willyborankin please correct me if I am wrong here.

@fabiojmendes
Copy link
Author

I see your point, but perhaps supporting aws out of the box would be worth the trade off.

I believe that using opensearch as an aws service is a very common use case.

@willyborankin
Copy link
Collaborator

@fabiojmendes I believe we do not intent to bundle vendor specific schemes into the connector but offer the capability to have it packaged / bundled with additional JARs that could be loaded using ServiceLoader mechanism, @willyborankin please correct me if I am wrong here.

@reta TBH I do not see any problems with adding it to the connector. It is a "kinda" connector way. In any case configuration for custom certificates needs to be added as well.

@willyborankin
Copy link
Collaborator

@fabiojmendes I believe we do not intent to bundle vendor specific schemes into the connector but offer the capability to have it packaged / bundled with additional JARs that could be loaded using ServiceLoader mechanism, @willyborankin please correct me if I am wrong here.

@reta TBH I do not see any problems with adding it to the connector. It is a "kinda" connector way. In any case configuration for custom certificates needs to be added as well.

@fabiojmendes. We do want to see you solution.I personally think this is a valuable feature. Since we need to add support SSL configuration it will take sometime. @reta I think we need to add a separate project which will build together with the connector as separate jar/jars with additional auth libs. Wdyt?

@fabiojmendes
Copy link
Author

Sounds good @willyborankin, do you need any changes from my side at this point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants