Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup vale #92

Merged
merged 8 commits into from
Sep 26, 2023
Merged

Setup vale #92

merged 8 commits into from
Sep 26, 2023

Conversation

programmiri
Copy link
Contributor

@programmiri programmiri commented Sep 25, 2023

Description

This PR introduces Vale. The setup is meant to be extended over time in order to establish a more strict style guide for our documentation. At the moment, Vale does basic spell checking.

  • Aiven also uses Vale, e.g. in devportal

This PR

  • adds Vale setup (see .vale.ini and .github/vale
  • add "Google" as style package, which applies some rules from the Google developer documentation style guide. (devportal follows this style guide)
  • adds a custom Klaw dictionary with custom vocabulary
  • adds README for vale setup
  • adds GitHub workflow for vale with documentation
  • adds customs scripts to run Vale locally
  • extends developer documentation with information about Vale

@programmiri programmiri linked an issue Sep 25, 2023 that may be closed by this pull request
@programmiri programmiri self-assigned this Sep 25, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 25, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2a22846
Status: ✅  Deploy successful!
Preview URL: https://eb4491be.klaw-docs.pages.dev
Branch Preview URL: https://86-setup-vale.klaw-docs.pages.dev

View logs

@programmiri programmiri force-pushed the 86-setup-vale branch 4 times, most recently from f807f54 to 70c59c1 Compare September 25, 2023 14:42
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
@programmiri programmiri marked this pull request as ready for review September 26, 2023 07:44
Copy link

@mathieu-anderson mathieu-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty amazing, learned a lot ^^

.github/vale/dicts/klaw.dic Show resolved Hide resolved
nonword: true
action:
name: replace
swap:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha amazing. Will do this in my writing ^^

.github/vale/styles/Google/Periods.yml Show resolved Hide resolved
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
@programmiri
Copy link
Contributor Author

@mathieu-anderson I sneaked in two commits, one adding info about vale sync in the docs and one renaming the docs files from "README" to be specific about their content, that way they are a bit easier to find when searching for files names.

@programmiri programmiri merged commit 76aa9ea into main Sep 26, 2023
5 checks passed
@programmiri programmiri deleted the 86-setup-vale branch September 26, 2023 08:40
harshini-rangaswamy pushed a commit that referenced this pull request Oct 4, 2023
* Add basic vale setup with base rules.
* Fix some spelling inconsistencies
* Add workflow for vale
* Update documentation

---------

Signed-off-by: Mirjam Aulbach <[email protected]>
muralibasani added a commit that referenced this pull request Oct 5, 2023
* Adding topic overview

Signed-off-by: muralibasani <[email protected]>

* Reviewed and edited content to add more information

Signed-off-by: Harshini Rangaswamy <[email protected]>

* Removed duplicate content

Signed-off-by: Harshini Rangaswamy <[email protected]>

* Run prettier check

Signed-off-by: Harshini Rangaswamy <[email protected]>

* (fix): Update custom css (#90)

Update custom css

Signed-off-by: Mirjam Aulbach <[email protected]>

* Add workflow for linting and markdown-link-check (#87)

- Add workflow for linting.
- Add script to check markdown links.
- Add explanation to script.
- Add github workflow for link-check.
- Add README for github workflows.

---------

Signed-off-by: Mirjam Aulbach <[email protected]>

* Setup vale (#92)

* Add basic vale setup with base rules.
* Fix some spelling inconsistencies
* Add workflow for vale
* Update documentation

---------

Signed-off-by: Mirjam Aulbach <[email protected]>

* Add tech docs for contributing (#96)

* Add CONTRIBUTING file with first important information.
* Update TOC and language.
* Reviewed and updated sentences in the  CONTRIBUTING file
* Rewrote sentence to provide more clarity

---------

Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Harshini Rangaswamy <[email protected]>
Co-authored-by: Harshini Rangaswamy <[email protected]>

* (fix): 🐛 duplicate documentation pages created (#94)

* Delete index.md file in concept and howto as they are generated in category.json


---------

Signed-off-by: Mirjam Aulbach <[email protected]>

* Configure vale more (#97)

* Use style config instead of dic for common words.

Signed-off-by: Mirjam Aulbach <[email protected]>

* Add custom styles for heading and whitespaces.

Signed-off-by: Mirjam Aulbach <[email protected]>

* Add proselint

Signed-off-by: Mirjam Aulbach <[email protected]>

* Add branding file.

Signed-off-by: Mirjam Aulbach <[email protected]>

* Be more specific with config.

Signed-off-by: Mirjam Aulbach <[email protected]>

* Update vale workflow.

Signed-off-by: Mirjam Aulbach <[email protected]>

* Add updated style rules.

Signed-off-by: Mirjam Aulbach <[email protected]>

---------

Signed-off-by: Mirjam Aulbach <[email protected]>

* Add additional rules (#108)

* Add style rule for postgresdb

Signed-off-by: Mirjam Aulbach <[email protected]>

* Add rule for condensending language

Signed-off-by: Mirjam Aulbach <[email protected]>

* Add rule for use of race related words and update error.

Signed-off-by: Mirjam Aulbach <[email protected]>

---------

Signed-off-by: Mirjam Aulbach <[email protected]>

* Update docs to use SSL correctly (#112)

Signed-off-by: Devrishi <[email protected]>

* Add first entries to style guide (#107)

Add first entries to style guide.

Signed-off-by: Mirjam Aulbach <[email protected]>

* fixes: Update doc term klaw correctly (#114)

* fixes: Update doc term klaw correctly

---------

Signed-off-by: Basavarajakjbasuu <[email protected]>

* (ci) Update vale workflow reporter (#115)

* Remove vale action in favor for own setup for workflow

Signed-off-by: Mirjam Aulbach <[email protected]>

* Move klaw rule to temp branding again.

Signed-off-by: Mirjam Aulbach <[email protected]>

* Fix spelling error.

Signed-off-by: Mirjam Aulbach <[email protected]>

---------

Signed-off-by: Mirjam Aulbach <[email protected]>

* Updated branding.yml and respective files to help docs to use the term "Confluent Cloud" correctly. (#122)

Updated branding.yml and respective files to help docs to use the term Confluent Cloud correctly

Signed-off-by: Roshan Goswami <[email protected]>

* Update docs to use Klaw Cluster API correctly  (#125)

Update docs to use Klaw Cluster API corrrectly

Signed-off-by: Devrishi <[email protected]>

* Added readme to spelling-klaw-vocabulary file

Signed-off-by: Harshini Rangaswamy <[email protected]>

---------

Signed-off-by: muralibasani <[email protected]>
Signed-off-by: Harshini Rangaswamy <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Devrishi <[email protected]>
Signed-off-by: Basavarajakjbasuu <[email protected]>
Signed-off-by: Roshan Goswami <[email protected]>
Co-authored-by: muralibasani <[email protected]>
Co-authored-by: Harshini Rangaswamy <[email protected]>
Co-authored-by: Mirjam Aulbach <[email protected]>
Co-authored-by: Devrishi Dutta <[email protected]>
Co-authored-by: Basavaraja K J <[email protected]>
Co-authored-by: Roshan <[email protected]>
Co-authored-by: Harshini Rangaswamy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup vale
2 participants