Fix proffered username sso configuration #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aindriu Lavelle <[email protected]>
Signed-off-by: Aindriu Lavelle <[email protected]>
Signed-off-by: Aindriu Lavelle <[email protected]>
Deploying klaw-docs with
|
| Latest commit: |
2bc4dc7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://812af747.klaw-docs.pages.dev |
| Branch Preview URL: | https://fix-preffered-username-sso.klaw-docs.pages.dev |
muralibasani
requested changes
Aug 2, 2024
There was a problem hiding this comment.
We could update klaw BE code to handle this claim internally, instead of asking user to update the claim. Ideally Klaw is dealing only with preferred usernames and not with email ids. And preferred usernames can be email ids.
IMO, this change is not required, rather we should update BE code in klaw
| 6. Each SSO provider can have a different "preferred username" attribute which identifies your user correctly. | ||
| For Google update this attribute in the application.properties as below. | ||
|
|
||
| `klaw.ad.username.attribute=email` |
There was a problem hiding this comment.
We should not force the organization to update this claim, as preferred_username can also be present in google SSO claims.
Signed-off-by: Aindriu Lavelle <[email protected]>
…cs into fix-preffered-username-sso
muralibasani
reviewed
Aug 2, 2024
docs/authentication-authorization/authentication/third-party-account.md
Outdated
Show resolved
Hide resolved
…ccount.md Co-authored-by: Murali Basani <[email protected]>
| Check your provider's documentation and select the attribute/claim that defines the username/login name. | ||
| Update this attribute in the `application.properties` file, replacing 'preferred_username' with their attribute. | ||
|
|
||
| `klaw.ad.username.attribute=preferred_username` |
There was a problem hiding this comment.
We can update this pr abit based on the pr Aiven-Open/klaw#2556
|
I've overridden DCO as the unsigned commits were mine. |
muralibasani
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added additional information on setting up SSO with Klaw after an issue was raised recently.