Adding google analytics tag #148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: muralibasani <[email protected]>
Deploying with
|
| Latest commit: |
86235d4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f3212cbc.klaw-docs.pages.dev |
| Branch Preview URL: | https://analytics.klaw-docs.pages.dev |
|
@muralibasani there's a linting error it seems, should be fixable by running This should have popped up in the pre-commit hook 🤔 not sure why it seems not to have. |
|
I don't think we should release that without setting up a cookie banner getting user consent and potential opt-out to be compliant with GDPR. Google has a post for that: https://www.cookiebot.com/en/google-analytics-gdpr/ Aiven also has internal information, but I'm not sure what applies to us (bc different domain etc) so we should check that out, too. |
Signed-off-by: Mirjam Aulbach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.