New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update-klaw-core #130

Closed

Rawshansharma wants to merge 5 commits into Aiven-Open:main from Rawshansharma:update-klaw-core

Contributor

Rawshansharma commented Oct 4, 2023

Fix #103

Rawshansharma force-pushed the update-klaw-core branch from 7c6f21f to bad853e Compare

October 4, 2023 11:04

programmiri reviewed

View reviewed changes

Contributor

programmiri left a comment

Thanks for your PR 🙏 I left two comments.

.github/vale/styles/Klaw/branding-warning-temp.yml

@@ @@ -7,6 +7,4 @@ ignorecase: true @@
               swap:
                 "(?<!Apache )kafka": Apache Kafka
                 "(?i)api": API
-                "(?i)kafka connect": Kafka Connect
-                "(?i)klaw core": Klaw Core
-                "(?i)klaw": Klaw

Contributor

programmiri Oct 4, 2023

Removing the rules for "Klaw" and "Kafka Connect" from here should not be part of this PR, could you remove that?

Contributor

programmiri Oct 6, 2023

Could you also remove the rule for "Kafka Connect"? It's not part of this PR.

.github/vale/styles/Klaw/branding.yml Outdated Show resolved Hide resolved

Rawshansharma added 3 commits

October 6, 2023 12:05


          update-klaw-core

a801d28

Signed-off-by: Raushan Sharma <[email protected]>


          update-klaw-core

855ba7d

Signed-off-by: Raushan Sharma <[email protected]>


          update-klaw-core

9817b84

Signed-off-by: Raushan Sharma <[email protected]>

Rawshansharma force-pushed the update-klaw-core branch from f00a66b to 9817b84 Compare

October 6, 2023 06:35


          Merge branch 'main' into update-klaw-core

8730cd9

programmiri reviewed

View reviewed changes

.github/vale/styles/Klaw/branding-warning-temp.yml

@@ @@ -7,6 +7,4 @@ ignorecase: true @@
               swap:
                 "(?<!Apache )kafka": Apache Kafka
                 "(?i)api": API
-                "(?i)kafka connect": Kafka Connect
-                "(?i)klaw core": Klaw Core
-                "(?i)klaw": Klaw

Contributor

programmiri Oct 6, 2023

Could you also remove the rule for "Kafka Connect"? It's not part of this PR.

README.md

@@ @@ -5,7 +5,7 @@ @@
               ## About
               This is the Klaw documentation repository. Welcome 👋 🎉
-              You can find source code and all content for our ([klaw-project.io](https://www.klaw-project.io/) site here.
+              You can find source code and all content for our ([Klaw-project.io](https://www.klaw-project.io/) site here.

Contributor

programmiri Oct 6, 2023

Changing spelling of "Klaw" should not be part of this PR, since it's for the rule "Klaw Core", can you reverse this one?

docs/HowTo/authentication/google-account.md

 .  Configure an existing SUPERADMIN user from AD to approve new users in the following property for username:
-                  <klaw[email protected]>
+                  <Klaw[email protected]>

Contributor

programmiri Oct 6, 2023

Changing spelling of "Klaw" should not be part of this PR, since it's for the rule "Klaw Core", can you reverse this one?

docs/HowTo/authentication/userpwd-db.md

                   encryption key to encrypt your password before it is stored in the database. The encryption key is used to secure and
                   protect your password.
-                  klaw.jasypt.encryptor.secretkey=kw2021secretkey
+                  Klaw.jasypt.encryptor.secretkey=kw2021secretkey

Contributor

programmiri Oct 6, 2023

Changing spelling of "Klaw" should not be part of this PR, since it's for the rule "Klaw Core", can you reverse this one?

docs/HowTo/clusterconnectivity/aiven-kafka-cluster-ssl-protocol.md

@@ @@ -50,7 +50,7 @@ Kafka® and Klaw using SSL protocol: @@
                  icon that is available on the right-hand side of each cluster
                  row.
 . Open the `application.properties` file located in the
-                 [klaw/cluster-api/src/main/resources] directory.
+                 [Klaw/cluster-api/src/main/resources] directory.

Contributor

programmiri Oct 6, 2023

Changing spelling of "Klaw" should not be part of this PR, since it's for the rule "Klaw Core", can you reverse this one?

docs/Releases/release240.md

               [cluster-api-2.4.0.jar ⬇](https://github.com/Aiven-Open/klaw/releases/download/v2.4.0/cluster-api-2.4.0.jar)
               ### Sources
-              [klaw-2.4.0.zip ⬇](https://github.com/Aiven-Open/klaw/archive/refs/tags/v2.4.0.zip)
+              [Klaw-2.4.0.zip ⬇](https://github.com/Aiven-Open/klaw/archive/refs/tags/v2.4.0.zip)

Contributor

programmiri Oct 6, 2023

Changing spelling of "Klaw" should not be part of this PR, since it's for the rule "Klaw Core", can you reverse this one?

docs/Releases/release250.md

@@ @@ -16,13 +16,13 @@ schemas from schema registry to Klaw, and vice versa. @@
               ### Binaries
-              [klaw-2.5.0.jar ⬇︎](https://github.com/Aiven-Open/klaw/releases/download/v2.5.0/klaw-2.5.0.jar)
+              [Klaw-2.5.0.jar ⬇︎](https://github.com/Aiven-Open/klaw/releases/download/v2.5.0/klaw-2.5.0.jar)

Contributor

programmiri Oct 6, 2023

Changing spelling of "Klaw" should not be part of this PR, since it's for the rule "Klaw Core", can you reverse this one?

docs/Releases/release250.md

               [cluster-api-2.5.0.jar ⬇](https://github.com/Aiven-Open/klaw/releases/download/v2.5.0/cluster-api-2.5.0.jar)
               ### Sources
-              [klaw-2.5.0.zip ⬇](https://github.com/Aiven-Open/klaw/archive/refs/tags/v2.5.0.zip)
+              [Klaw-2.5.0.zip ⬇](https://github.com/Aiven-Open/klaw/archive/refs/tags/v2.5.0.zip)

Contributor

programmiri Oct 6, 2023

Changing spelling of "Klaw" should not be part of this PR, since it's for the rule "Klaw Core", can you reverse this one?

docs/Releases/release251.md

               ### Binaries
-              - [klaw-2.5.1.jar ⬇︎](https://github.com/Aiven-Open/klaw/releases/download/v2.5.1/klaw-2.5.1.jar)
+              - [Klaw-2.5.1.jar ⬇︎](https://github.com/Aiven-Open/klaw/releases/download/v2.5.1/klaw-2.5.1.jar)

Contributor

programmiri Oct 6, 2023

Changing spelling of "Klaw" should not be part of this PR, since it's for the rule "Klaw Core", can you reverse this one?

docs/Releases/release251.md

               - [cluster-api-2.5.1.jar ⬇](https://github.com/Aiven-Open/klaw/releases/download/v2.5.1/cluster-api-2.5.1.jar)
               ### Sources
-              - [klaw-2.5.1.zip ⬇](https://github.com/Aiven-Open/klaw/archive/refs/tags/v2.5.1.zip)
+              - [Klaw-2.5.1.zip ⬇](https://github.com/Aiven-Open/klaw/archive/refs/tags/v2.5.1.zip)

Contributor

programmiri Oct 6, 2023

Changing spelling of "Klaw" should not be part of this PR, since it's for the rule "Klaw Core", can you reverse this one?

Rawshansharma requested a review from programmiri

October 11, 2023 11:34

Contributor

programmiri commented Oct 12, 2023

Hi @Rawshansharma I see you requested a new review. Did you check the comments I left? I can't see changes related to that, could you make sure your PR is up to date?


          Merge branch 'main' into update-klaw-core

35ff8da

Rawshansharma marked this pull request as draft

October 16, 2023 14:17

Contributor

programmiri commented Oct 24, 2023

Hi @Rawshansharma do you want to continue with this PR? It's stale for a bit now. It's not a problem if you don't, I just need to know, so I could open the issue up again for other Hacktoberfest folks :) If I don't hear from you, I would do that by end of the week.

Contributor

programmiri commented Oct 30, 2023

Hi! I'm going to close this pull request and open the issue up again in case someone wants to add some contribution to hacktoberfest right before the end.

programmiri closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet