-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fastapi schema-registry
module with DI and E2E tests
#995
feat: fastapi schema-registry
module with DI and E2E tests
#995
Conversation
74c54af
to
d336032
Compare
d336032
to
f52fe6c
Compare
60a8086
to
7b8cd91
Compare
- we create a standalone module for SR related components - we use DI to wire together the SR dependencies - we move the routers to own folder - we move the config initialization to DI and app startup
- we add a docker compose service which would act like a CLI - we add a dev Dockerfile - we drop python3.9 from the tests matrix as pydantic-settings has issues with python3.9 - we add .env files for both registry and rest
- we replace use the karapace container to load the default config
f52fe6c
to
6b3523a
Compare
ca5d5e3
to
664a637
Compare
e04c86a
to
10878e7
Compare
Coverage reportClick to see where and how coverage changed
The report is truncated to 25 files out of 28. To see the full report, please visit the workflow summary page. This report was generated by python-coverage-comment-action |
82396f1
to
c3b0ec9
Compare
5115f7f
to
364c47c
Compare
- we split out e2e tests into own folder - e2e tests will run against the service in docker compose - we start by splitting out the prometheus and kafka e2e tests which do not need local running services
364c47c
to
af56c95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, getting rather large and preferable to merge. Most integration tests pass, forwarding tests have some issues. Linting and other issues can be resolved in subsequent PRs.
About this change - What it does
Some changes based off the work from the jjaakola-aiven-fastapi branch, majorly:
e2e
foldere2e
tests were introduced, which also run within a docker compose environmentintegration
tests folder slowly into thee2e
tests foldere2e
tests run against the karapace docker compose services: i.e.schema-registry/rest
rather than local processesrapu
.env
file.env
file needed to populate the rest of the configsentry
config was added, we need to revisit this.