tests, avro: add test on invalid reference schema #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous port selection algorithm relied on port range. The range was from 48700 to 49000. This is 300 ports of which some may be already reserved in the system running tests. The free ports are allocated between the pytest workers. With 4 workers there is 75 ports for each. This causes flakiness in the tests as ports may not be available or are still in wait after previous tests. In the test environment it is not necessary to select ports from IANA dynamic port assignment range. Any free port is ok and port 0 can be used for dynamically allocated free port.
…ports-with-0-in-tests test: select random free server ports with 0
…chema-coordinator-test-with-retries test: add retries to schema coordinator workflow test
The test is naturally flaky. The lowest timeout is 1 ms and it is possible to get the response in that time from Kafka. The super class cannot be mocked easily as it is immutable.
…mmitted-flaky-test test: remove flaky TestCommitted test
…dling-tests tests, protobuf: add test on invalid reference schema
…om-logs test: add a test that detect duplicate ids in a backup of thei `_schemas` topic
- we add the kafka message key to the log in the case of an error, this makes it easier to debug issues - we also add a check for kafka messages without a key
…a-reader-error schema-reader: Log the erroring kafka message key
davide-armand
changed the base branch from
main
to
avro_references2-rebased
|
New PR with the correct base branch: #966 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #962, but for AVRO