fix cache: the cache metadata its always replaced even if its only updating a subportion of it #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliax1996
force-pushed
the
eliax1996/fix-cache-for-user-rest-proxy
branch
3 times, most recently
from
79ac106 to
afe8403
Compare
jjaakola-aiven
previously requested changes
Jun 4, 2024
eliax1996
force-pushed
the
eliax1996/fix-cache-for-user-rest-proxy
branch
3 times, most recently
from
ade8f80 to
624f745
Compare
eliax1996
force-pushed
the
eliax1996/fix-cache-for-user-rest-proxy
branch
from
624f745 to
3748e61
Compare
eliax1996
changed the title
eliax1996
changed the title
eliax1996
force-pushed
the
eliax1996/fix-cache-for-user-rest-proxy
branch
from
3748e61 to
be669bd
Compare
…en if the metadata request was just for a subset of topics, this pr tries to address this by updating only partially the metadata object
eliax1996
force-pushed
the
eliax1996/fix-cache-for-user-rest-proxy
branch
from
be669bd to
7d7fdf6
Compare
jjaakola-aiven
previously requested changes
Jun 5, 2024
There was a problem hiding this comment.
test_rest_proxy_cluster_metadata_cache.py?
eliax1996
force-pushed
the
eliax1996/fix-cache-for-user-rest-proxy
branch
from
26080c2 to
d7ea187
Compare
eliax1996
force-pushed
the
eliax1996/fix-cache-for-user-rest-proxy
branch
from
d7ea187 to
121bf3b
Compare
jjaakola-aiven
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the cache each time was replacing the original metadata even if the metadata request was just for a subset of topics, this pr tries to address this by updating only partially the metadata object
About this change - What it does
References: #xxxxx
Why this way