Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not skip None keyed headers on restore #777

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Do not skip None keyed headers on restore #777

merged 1 commit into from
Dec 6, 2023

Conversation

matyaskuti
Copy link
Contributor

@matyaskuti matyaskuti commented Dec 6, 2023 •
edited
Loading

About this change - What it does

Why this way

  • Restoring previous behaviour

Do not skip None keyed headers on restore
c9f1492 
Previously in #765 skipping
None header keys was added. While now it's not causing any problems, in
the future it could be an issue if we suppress/skip error-cases instead
of explicit failure.
@matyaskuti matyaskuti marked this pull request as ready for review December 6, 2023 14:39
@matyaskuti matyaskuti requested review from a team as code owners December 6, 2023 14:39
eliax1996
eliax1996 approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@eliax1996 eliax1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this and for didn't indulge my paranoia :)

@eliax1996 eliax1996 merged commit f247134 into main Dec 6, 2023
8 checks passed
@eliax1996 eliax1996 deleted the matyaskuti/backups_headers branch December 6, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliax1996 eliax1996 eliax1996 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matyaskuti @eliax1996