Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing stubs for confluent-kafka #760

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

matyaskuti
Copy link
Contributor

@matyaskuti matyaskuti commented Nov 15, 2023

About this change - What it does

Building on #757, adding typing stubs for the confluent-kafka-python library.

Why this way

Adding stubs only for the features we use from the library.

Base automatically changed from matyaskuti/confluent_kafka_for_admin_client to main November 20, 2023 14:21
@matyaskuti matyaskuti force-pushed the matyaskuti/confluent_kafka_admin_stubs branch from c1381f7 to 210bd76 Compare November 20, 2023 14:26
@matyaskuti matyaskuti marked this pull request as ready for review November 20, 2023 14:30
@matyaskuti matyaskuti requested review from a team as code owners November 20, 2023 14:30
Copy link
Contributor

@eliax1996 eliax1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked before and to me seems fine 😄
I didn't really looked every signature and every returned type in the real implementation though

@aiven-anton aiven-anton merged commit b3cb8e8 into main Nov 20, 2023
8 checks passed
@aiven-anton aiven-anton deleted the matyaskuti/confluent_kafka_admin_stubs branch November 20, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants