Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authentication check with referencedby route #756

Merged
merged 1 commit into from
Nov 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions karapace/schema_registry_apis.py
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,7 @@ def _add_schema_registry_routes(self) -> None:
callback=self.subject_version_referencedby_get,
method="GET",
schema_request=True,
auth=self._auth,
)
self.route(
"/subjects/<subject:path>",
Expand Down
3 changes: 3 additions & 0 deletions tests/integration/test_schema_registry_auth.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,9 @@ async def test_sr_auth_endpoints(registry_async_client_auth: Client) -> None:
res = await registry_async_client_auth.get(f"subjects/{quote(subject)}/versions/1/schema")
assert res.status_code == 401

res = await registry_async_client_auth.get(f"subjects/{quote(subject)}/versions/1/referencedby")
assert res.status_code == 401

res = await registry_async_client_auth.delete(f"subjects/{quote(subject)}")
assert res.status_code == 401

Expand Down