Added support to other naming strategy #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliax1996
force-pushed
the
eliax1996/general-refactor-of-different-components
branch
2 times, most recently
from
3221250 to
b90af7b
Compare
tvainika
previously requested changes
Nov 3, 2023
eliax1996
force-pushed
the
eliax1996/general-refactor-of-different-components
branch
3 times, most recently
from
af7f346 to
3471482
Compare
eliax1996
force-pushed
the
eliax1996/general-refactor-of-different-components
branch
from
3471482 to
462d3b7
Compare
eliax1996
force-pushed
the
eliax1996/general-refactor-of-different-components
branch
2 times, most recently
from
bc0bfd7 to
a7d0843
Compare
tvainika
previously requested changes
Nov 8, 2023
eliax1996
force-pushed
the
eliax1996/general-refactor-of-different-components
branch
from
a7d0843 to
952b9f4
Compare
eliax1996
force-pushed
the
eliax1996/general-refactor-of-different-components
branch
from
952b9f4 to
74b4cc9
Compare
tvainika
previously approved these changes
Nov 9, 2023
…d stuff and added a couple of tests
eliax1996
force-pushed
the
eliax1996/general-refactor-of-different-components
branch
from
74b4cc9 to
535d652
Compare
giuseppelillo
approved these changes
Nov 9, 2023
giuseppelillo
deleted the
eliax1996/general-refactor-of-different-components
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before that commit the other strategies where existing but not effectively usable/tested in the codebase.
This pr adds the support and set tests to effectively test the naming strategies.
During the development I've also added a little bit more typing over the files I've touched to improve the codebase