feat: add version of karapace to the healthcheck response #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eliax1996
commented
Oct 23, 2023
eliax1996
commented
- Added the Karapace version to the healthcheck reply
- Added typing in the parameters of the file
aiven-anton
previously requested changes
Oct 23, 2023
eliax1996
force-pushed
the
eliax1996/add-karapace-version-in-health-reply
branch
from
7976b0c to
109da9d
Compare
eliax1996
force-pushed
the
eliax1996/add-karapace-version-in-health-reply
branch
3 times, most recently
from
394944b to
1184322
Compare
aiven-anton
previously approved these changes
Oct 23, 2023
eliax1996
force-pushed
the
eliax1996/add-karapace-version-in-health-reply
branch
from
1184322 to
303088e
Compare
aiven-anton
deleted the
eliax1996/add-karapace-version-in-health-reply
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.