Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add another couple of basic tests #722

Closed
wants to merge 2 commits into from

Conversation

eliax1996
Copy link
Contributor

Even if the scope of the tests could be covered by others I think those are worth being added for a couple of reasons:

  1. the avro test shows how to register two different subjects (one for the key and the other for the value) even if the schema is the same to produce correctly an avro message in a topic
  2. the protobuf test shows that basic google entities are already included in the karapace schema but it works also if you register it explicitly

@eliax1996 eliax1996 requested review from a team as code owners September 25, 2023 13:03
@eliax1996 eliax1996 force-pushed the eliax1996/add-basic-tests branch from 3f59f63 to 6e51f50 Compare September 25, 2023 13:04
@eliax1996 eliax1996 force-pushed the eliax1996/add-basic-tests branch from 6e51f50 to 0aef6f2 Compare September 25, 2023 13:08
@eliax1996
Copy link
Contributor Author

@jjaakola-aiven have you seen that the test it's failing, shouldn't be the google referenced type be one of the well known and already pre-installed? Because it's failing the test that use the import without register it first

@eliax1996
Copy link
Contributor Author

I've tried to fix that but basically doesn't seems to be easy to fix. I've even attempted during the test setup phase to create the file in the right folder but doesn't seem to be enough to make work the test with the schema added by the proto dependency.

To me sounds fishy that we rely on the schemas being already there but in practice we don't have a test for it (unless I've missed it).

Closing the pr unless I discover how to make the provided schema visible from the protoc executable

@eliax1996 eliax1996 closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants