chore: Make pytest CI runs more verbose #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you sure about removing |
|
@juha-aiven Yeah I really don't see the point of shortening tracebacks, especially not in CI for a parallelized test suite (due to hard to deterministically recreate exact order of execution). In the case mentioned I can't tell where the call originated due to tb short. It's still easy to override these settings in dev envs to have differing behavior there. |
OK, just wanted to double-check this is intentional. |
tvainika
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Increase pytest verbosity, by removing the quiet flag as well as the
--tb=shortflag.Why this way
In this failing CI run, the fact that we use
--tb shortmakes it impossible to tell what code path triggered the breaking call toread_config().https://github.com/Aiven-Open/karapace/actions/runs/6239301084/job/16936931606