Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

senders: check tags for None keys/values #170

Merged
merged 2 commits into from
May 27, 2024

Conversation

tkren
Copy link
Contributor

@tkren tkren commented May 24, 2024

Only include tags that have no None-valued keys/values.

Only include tags that have no None-valued keys/values.
@tkren tkren marked this pull request as ready for review May 24, 2024 21:08
Copy link
Contributor

@giacomo-alzetta-aiven giacomo-alzetta-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add some test to verify the behavior and avoid regressions in the future.

@tkren tkren dismissed giacomo-alzetta-aiven’s stale review May 26, 2024 21:31

Implemented requested changes

Copy link
Contributor

@giacomo-alzetta-aiven giacomo-alzetta-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giacomo-alzetta-aiven giacomo-alzetta-aiven merged commit 9803f9c into master May 27, 2024
6 checks passed
@giacomo-alzetta-aiven giacomo-alzetta-aiven deleted the teakay-drop-none-tags branch May 27, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants