fix: resume from reader cursor when no senders configured #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where a reader was configured with no senders (eg. only configured with searches), then in case of reloads/restarts the resume cursor was assumed `None`, and the default 'initial_position' of 'head' is fallen back to. This would end up causing all matching searchg to resend metric events immediately.
ngilles-aiven
force-pushed
the
ngilles/resume-from-read-cursor-when-no-senders
branch
from
14d8214 to
7d01dac
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #167 +/- ##
==========================================
- Coverage 63.61% 63.23% -0.39%
==========================================
Files 19 19
Lines 2086 2086
==========================================
- Hits 1327 1319 -8
- Misses 759 767 +8
|
aiven-amartin
approved these changes
Mar 15, 2024
aiven-amartin
deleted the
ngilles/resume-from-read-cursor-when-no-senders
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where a reader was configured with no senders (eg. only configured with searches), then in case of reloads/restarts the resume cursor was assumed
None, and the default 'initial_position' of 'head' is fallen back to. This would end up causing all matching searchg to resend metric events immediately.