-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a threshold for search if want to emit a metric #165
Conversation
What if the search never finishes though? I think this is better served by converting to using re2! |
95362f1
to
695f21b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #165 +/- ##
==========================================
+ Coverage 63.13% 63.32% +0.19%
==========================================
Files 19 19
Lines 2083 2094 +11
==========================================
+ Hits 1315 1326 +11
Misses 768 768
|
695f21b
to
c39c401
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments. Also, is there any test coverage for this change?
c39c401
to
7d0e907
Compare
7d0e907
to
18b6bac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't see the test you added
18b6bac
to
50e228e
Compare
hmm, it was there at commit: 7d0e907, I did something wrong yesterday probably |
50e228e
to
d65493b
Compare
in case some bad regex search defined, it would be easier to identify the offender
d65493b
to
e06ad2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
in case some bad regex search defined,
it would be easier to identify the offender
The threshold is defined as threshold_for_metric_emit with default value 10 seconds.
The metric would look like this:
with regex tag on it.