Migrate from pylint and flake8 to ruff #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aris-aiven
force-pushed
the
aris-pre-commit-update
branch
from
fe5719e to
955a533
Compare
aris-aiven
changed the title
aris-aiven
force-pushed
the
aris-pre-commit-update
branch
2 times, most recently
from
e01155e to
146ee43
Compare
joelynch
previously requested changes
Oct 23, 2024
Makefile
Outdated
Comment on lines
64
to
66
| .PHONY: isort | ||
| isort: | ||
| isort: $(GENERATED) | ||
| pre-commit run isort --all-files |
There was a problem hiding this comment.
Do we still need isort? Ruff sorts imports.
There was a problem hiding this comment.
Good idea, just removing isort b/c the current ruff config should cover sorting AFAICT
It is superseded by a ruff rule
joelynch
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update pre-commit hooks and transition to ruff.
This simplifies the linting workflow and improves its performance.