Implement zoom panel for control scale of media container #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had one misfunction behavior, panel description updated only when settings panel closed and open again. I guess that I need to add a trigger for the value change event, but I don't have enough knowledge for that. |
SangwonOh
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the zoom functionality for the css property of the media container.
For me personally I need to zoom when I stream content with unpopular aspect ratio and for those who are watching this button is useful to get rid of black bars on the top/bottom of the screen
I'm not sure if the code is correct, but as agreed in #300 Mr. @SangwonOh will help in bringing this feature to its final state.