Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLTFRS-16388 Switch to AWS SDK v2 #6

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

PLTFRS-16388 Switch to AWS SDK v2 #6

wants to merge 14 commits into from

Conversation

bplessis-swi
Copy link
Collaborator

A little work on overlord to fix some issues, enhance and strengthen it a little :

  • remove file-base state not pertinent since state removed at startup
  • switch to aws sdk v2 and recent golang standard
  • ability to set configuration root path on cmd line to help testings
  • start to include 'offline' tests using dependency injection idiom
  • remove extra aws api call in ASG processing (DescribeTags) since it can be done using the main DescribeAutoScalingGroups similar to tag/ec2 and subnets
  • replace the ResourceSet datastructure by a slice since there wasn't any real way to have duplicate anyway
  • Track the list of template to detect more accurately changes

@bplessis-swi bplessis-swi marked this pull request as draft January 5, 2023 08:49
@bplessis-swi
State file is removed on startup, so it's not very useful, Use an in-…
e4cb416 
…memory state instead
@bplessis-swi
Switch to aws sdk v2 for golang
bfc2512
@bplessis-swi
Add support for custom configuration path
2adf05f
@bplessis-swi
Add data structure tests and full tests configurations
8b82a2d 
Provide base tests for set.Strings and lookable.*, with dependencies injections for aws calls
Provide some resources/templates examples for full tests
@bplessis-swi
Remove un-necessary API call for ASG
0707f79 
Use instance level attributed IPv6 address in ipv6 mode
@bplessis-swi
Use slice/array append function
c10e11b
@bplessis-swi
Use standard array/slice datastructure for 'ResourceSet' which wasn't…
388bfae 
… used as a set, extract utility function
@bplessis-swi
Generify the set datastructure
48e1b73 
Extract the Resource, Changes and State structure
Extend the State structure to record more data to track added resource and templates changes
@bplessis-swi
dump version
653b5da
@bplessis-swi
Filter ASG listing for healthy and in services instances
8317e85
@bplessis-swi
attempt to create test cases for asg with mixed instances configuration
6860178
@bplessis-swi bplessis-swi changed the title Pltfrs 16388 PLTFRS-16388 Switch to AWS SDK v2 Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bplessis-swi