-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance queue management and interaction response #617
base: main
Are you sure you want to change the base?
Conversation
- Introduced a new `EditResponseAsync` method for string content. - Created `DefaultQueueEntry` class for track playback handling. - Updated `LavalinkConfiguration` with a customizable `QueueEntryFactory`. - Refactored `LavalinkGuildPlayer` to utilize a static `QueueInternal` for guild-specific queues. - Deprecated the `QueueEntries` property in favor of the new `Queue` property. - Implemented a new thread-safe `LavalinkQueue<T>` class for queue operations.
We don't use Obsolete anymore, instead we use Deprecated. We distribute our own code analyzers.
A few minor things I fixed:
|
To
I have no problem with adding it, but I don't think it'll be in use for long since discord is changing some stuff cough #601 cough |
Signed-off-by: Lala Sabathil <[email protected]>
got it |
no its fine, we'll leave it in |
We just have to test it out Solid work, many thanks |
Description
EditResponseAsync
method for string content.DefaultQueueEntry
class for track playback handling.LavalinkConfiguration
with a customizableQueueEntryFactory
.LavalinkGuildPlayer
to utilize a staticQueueInternal
for guild-specific queues.QueueEntries
property in favor of the newQueue
property.LavalinkQueue<T>
class for queue operations.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I really like the short, not too long way of writing.
The
EditResponseAsync
method is used a lot and I think the input is mainly a content, so I added a method input which is string content, hope you agree.tested the queue part with 3 servers and they work fine (only manual test, no automation test and code test).
In case the user only wants to use Queue(
EnableBuiltInQueueSystem = true
) and does not want to use pipeline queue entrya transient pipeline
DefaultQueueEntry
will be used.If they want to use it, just sets a
QueueEntryFactory
function that creates queue entry objects.We can use
QueueEntryFactory
with DIOtherwise we can create it with delegate instance
When playing the tracks it will also create a
transient
ofQueueEntryFactory
Test Configuration:
Checklist:
@Aiko-IT-Systems/discatsharp