Client-Side Sentry Filtering #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as abuse.
This comment was marked as abuse.
Lulalaby
reviewed
May 19, 2024
|
I think this can be merged, besides deeper level filtering there's nothing else that comes to mind. |
TheXorog
requested review from
Lulalaby and
JMLutra
and removed request for
geferon and
BloodDragooner
Co-authored-by: quinchs <>
Co-authored-by: quinchs <[email protected]>
Signed-off-by: Lala Sabathil <[email protected]>
…er if u manually call it might need more fixes
|
Documentation test build passed! 🎉 |
Lulalaby
added a commit
that referenced
this pull request
Jul 10, 2024
* feat: Add StripTokens Co-authored-by: quinchs <> * add breadcrumb filter * add before transaction filter * simplify implementation + and actually make it work in this use case * fix regex to actually match tokens & simplify Co-authored-by: quinchs <[email protected]> * Update DisCatSharp/Utilities.cs Signed-off-by: Lala Sabathil <[email protected]> * chore: fix docs * revert: ex can be in senex since it's not read by sentry itself, rather if u manually call it might need more fixes --------- Signed-off-by: Lala Sabathil <[email protected]> Co-authored-by: quinchs <[email protected]> Co-authored-by: Lala Sabathil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR further addresses #493 and #494.
@quinchs Feel free to double-check my work. I've used your method from #494 for this implementation, that's why i'm mentioning you.I replaced the method, noticed the original wouldnt actually work properly.