feat: Implement cooldowns for application commands #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lulalaby
changed the title
Lulalaby
changed the title
Lulalaby
requested review from
villChurch,
xMaxximum and
FabiChan99
and removed request for
Chibi310
Lulalaby
added
enhancement
Lulalaby
force-pushed
the
feat/discatsharp.applicationcommands-cooldowns
branch
2 times, most recently
from
7442c41 to
fc04960
Compare
Lulalaby
force-pushed
the
feat/discatsharp.applicationcommands-cooldowns
branch
2 times, most recently
from
ed6f9d8 to
9331d94
Compare
feat: move cooldown to discatsharp base package chore: some experimental stuff fix: commandsnext cooldowns
Lulalaby
force-pushed
the
feat/discatsharp.applicationcommands-cooldowns
branch
from
9331d94 to
c5029d8
Compare
Lulalaby
force-pushed
the
feat/discatsharp.applicationcommands-cooldowns
branch
from
59ad839 to
1ffb542
Compare
Lulalaby
force-pushed
the
feat/discatsharp.applicationcommands-cooldowns
branch
from
9fe2694 to
042abe0
Compare
…r non existent in advance
…s://github.com/Aiko-IT-Systems/DisCatSharp into feat/discatsharp.applicationcommands-cooldowns # Conflicts: # DisCatSharp.ApplicationCommands/ApplicationCommandsExtension.cs # DisCatSharp.ApplicationCommands/Entities/FakeApplicationCommandObjects.cs
…s://github.com/Aiko-IT-Systems/DisCatSharp into feat/discatsharp.applicationcommands-cooldowns
|
Documentation test build passed! 🎉 |
Lulalaby
added a commit
that referenced
this pull request
Jul 10, 2024
* feat: make cooldowns work feat: move cooldown to discatsharp base package chore: some experimental stuff fix: commandsnext cooldowns * [ci skip] chore: resharper disable for sealed on CooldownBucket * fix: try fixing translations (while i'm on it) * fix: really fix translation export * fix: fixed translations (while i'm on it) * feat: add by discord added allowed locales * [ci skip] chore: update release notes * fix: fix registration of applicaiton commands when commands cleared or non existent in advance * feat: custom cooldown responder * docs: fix space -> tab * Update RELEASENOTES.md * fix: fix registration of translations for subcommands * fix: nre * chore: remove command grouping type --------- Co-authored-by: Mira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cooldowns
This pull request adds capabilities for cooldowns in
CommandsNextandApplicationCommands+ CoreImplementation details
Cooldowns for CommandsNext add a ❌ reaction if the ratelimit was hit (but ignores if we don't have permissions).
Cooldowns for ApplicationCommands respond ephemeral with a message about the ratelimit hit and when to retry.
TODOs