Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: nullability & other things #341

Closed
wants to merge 122 commits into from
Closed

fix!: nullability & other things #341

wants to merge 122 commits into from

Conversation

Lulalaby
Copy link
Member

No description provided.

@Lulalaby Lulalaby added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed core Changes something in core labels Jul 27, 2023
@Lulalaby Lulalaby requested review from TheXorog and xMaxximum July 27, 2023 23:19
@NyuwBot NyuwBot removed the core Changes something in core label Jul 27, 2023
@TheXorog TheXorog force-pushed the cleanup/nullability-and-other-things branch from d6b3841 to 0a3b8ef Compare July 28, 2023 22:22
@Lulalaby Lulalaby changed the title fix!: nullabiliy & other things fix!: nullability & other things Jul 29, 2023
xMaxximum
xMaxximum previously requested changes Jul 30, 2023
View reviewed changes
Copy link
Member

@xMaxximum xMaxximum left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after looking at the changes

@Lulalaby
Copy link
Member Author

@xMaxximum this is still a draft XD
I just have enough of C# the weekend xD

@Lulalaby
Merge branch 'main' into cleanup/nullability-and-other-things
7092784
@Lulalaby
chore(code-style): and again.. and again.. arrrrrrgh
cc08ec3
@Lulalaby
Update ApplicationCommandEqualityChecks.cs
768272a
@Lulalaby
fix bs
fe6bff6
@Lulalaby
Merge branch 'main' into cleanup/nullability-and-other-things
ae4940c
@Lulalaby
?
baf8757
@Lulalaby
chore(code-cleanup): code cleanup for tools
36f2a6b
@Lulalaby
Merge remote-tracking branch 'origin/main' into cleanup/nullability-a…
ca9f0a7 
…nd-other-things
@Lulalaby
Revert "Merge remote-tracking branch 'origin/main' into cleanup/nulla…
01a73ad 
…bility-and-other-things"

This reverts commit ca9f0a7, reversing
changes made to 36f2a6b.
@Lulalaby
fix: bad request for scheduled events
ff34dac
@Lulalaby
Merge branch 'main' into cleanup/nullability-and-other-things
59f0d85
@Lulalaby
Update RestStageInstancePayloads.cs
fbd790d
@Lulalaby
Merge branch 'main' into cleanup/nullability-and-other-things
59e2161
@Lulalaby
Update DiscordApiClient.cs
fd095b7
@Lulalaby
Update DiscordSignedLink.cs
fe2ce7b
@Lulalaby
Merge branch 'main' into cleanup/nullability-and-other-things
40f7593
@Lulalaby Lulalaby marked this pull request as ready for review October 17, 2023 23:11
@Lulalaby Lulalaby requested review from NyuwBot and a team as code owners October 17, 2023 23:11
@Lulalaby Lulalaby marked this pull request as draft October 18, 2023 16:50
@github-actions
Copy link

Documentation test build passed! 🎉
Visit the cloudflare action run in https://github.com/Aiko-IT-Systems/DisCatSharp.Docs/commits/cleanup/nullability-and-other-things for details :3

gif

@Lulalaby Lulalaby mentioned this pull request Nov 5, 2023
Closed
@Lulalaby Lulalaby mentioned this pull request Nov 21, 2023
Merged
7 tasks
@Lulalaby Lulalaby closed this Dec 19, 2023
@Aiko-IT-Systems Aiko-IT-Systems locked and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xMaxximum xMaxximum xMaxximum left review comments

@TheXorog TheXorog Awaiting requested review from TheXorog

@NyuwBot NyuwBot Awaiting requested review from NyuwBot NyuwBot is a code owner

Assignees

@Lulalaby Lulalaby

@TheXorog TheXorog

Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lulalaby @xMaxximum @TheXorog @NyuwBot