Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load JSON data from web #151

Closed
wants to merge 7 commits into from
Closed

Load JSON data from web #151

wants to merge 7 commits into from

Conversation

rogys88
Copy link

@rogys88 rogys88 commented Oct 18, 2022

Fixed issue (#148) - App getting crash while passing proper json.

Task/Issue URL: #148

Fixed issue (Ahmed-Ali#148) - App getting crash while passing proper json.

Task/Issue URL: Ahmed-Ali#148
@rogys88
Copy link
Author

rogys88 commented Oct 18, 2022

Support for loading JSON data from web

@Ahmed-Ali Thanks for this amazing product and thanks to make my life easier. 🙂

I also change the text "Enter json data or" to "Enter json data/url or" and Update README To Do list:
Load JSON data from web Done

Screen Shot 2022-10-18 at 1 47 21 PM

@Ahmed-Ali
Copy link
Owner

Hi @rogys88, first off thank you so much for the PR! second off, I am really sorry it took so long to get to it. I promise I will do my best to be much more attentive for future PRs.

Lastly, if you can kindly revise the PR to resolve the conflicts, and update it to request to merge to develop instead of the master branch, that would be really appreciated!

@rogys88
Copy link
Author

rogys88 commented Aug 31, 2023

Hi @rogys88, first off thank you so much for the PR! second off, I am really sorry it took so long to get to it. I promise I will do my best to be much more attentive for future PRs.

Lastly, if you can kindly revise the PR to resolve the conflicts, and update it to request to merge to develop instead of the master branch, that would be really appreciated!

I just did it 😉

@Ahmed-Ali
Copy link
Owner

Thanks @rogys88! I believe you did that in PR #153 which is now merged. Hence I will close this one.

@Ahmed-Ali Ahmed-Ali closed this Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants