Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm sptf whc12 #32 #34

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Rm sptf whc12 #32 #34

wants to merge 3 commits into from

Conversation

BrentWHR
Copy link
Contributor

@BrentWHR BrentWHR commented May 4, 2023

Removes sptf_whc12 and add minor improvements to introduction vignette.

closes #32

@BrentWHR BrentWHR requested a review from gerardhros May 4, 2023 12:31
@gerardhros
Copy link
Collaborator

@BrentWHR , its not clear why its removed. I think the comments from Yuki in the function description needs an update rather than depreciating the function itself. Please look to the PTF_manual version 2.0, where on page 5 the Brooks-Corey equation is given, and the pedotransfer function of Rawls and Brakensiek (1985) is given at page 9. It seemed Yuki set saturated theta equal to porosity, equal to the assumption of Mayr and Jarvis (see page 10 in the same manual).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sptf_whc12 may not be using the ptf the description says it uses
2 participants