Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject giftcard #1216

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Reject giftcard #1216

wants to merge 2 commits into from

Conversation

amihajlovski
Copy link
Contributor

Summary

Describe the changes proposed in this pull request:

  • What is the motivation for this change?
    If giftcard result code is not success, payments request shouldn't be sent.
  • What existing problem does this pull request solve?

Tested scenarios

Description of tested scenarios:

  • Giftcards

Fixed issue: SFI-1033

@amihajlovski amihajlovski added the fix Fixes a bug label Nov 20, 2024
@amihajlovski amihajlovski deleted the bugfix/sfi-1033-reject-giftcard branch November 20, 2024 10:03
@amihajlovski amihajlovski reopened this Nov 20, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenit2001 zenit2001 zenit2001 approved these changes

@dcardos dcardos Awaiting requested review from dcardos dcardos is a code owner

@shanikantsingh shanikantsingh Awaiting requested review from shanikantsingh shanikantsingh is a code owner

@shubhamk67 shubhamk67 Awaiting requested review from shubhamk67 shubhamk67 is a code owner

@ShubhamVijaivargiya ShubhamVijaivargiya Awaiting requested review from ShubhamVijaivargiya ShubhamVijaivargiya is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
fix Fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amihajlovski @zenit2001