Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix excluding files properly #345

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Fix excluding files properly #345

merged 1 commit into from
Nov 11, 2024

Conversation

jillingk
Copy link
Contributor

Description

Tested scenarios

Fixed issue:

@jillingk jillingk requested a review from a team as a code owner November 11, 2024 10:12
Copy link

@karolyi
Copy link

karolyi commented Nov 11, 2024

Tested the fork locally, can confirm it works. Please merge and make a release at your earliest convenience.

@DjoykeAbyah DjoykeAbyah merged commit f5bb2ca into main Nov 11, 2024
6 checks passed
@DjoykeAbyah DjoykeAbyah deleted the fix-exclude-test-folder branch November 11, 2024 12:22
@jillingk
Copy link
Contributor Author

@karolyi

Amazing of you to quickly test this, merci!

@karolyi
Copy link

karolyi commented Nov 11, 2024

He who needs it, fixes it. A general rule of opensource. :)

@karolyi
Copy link

karolyi commented Nov 11, 2024

image
Say what?! Did you just re-release 12.4.0?

@DjoykeAbyah
Copy link
Member

DjoykeAbyah commented Nov 11, 2024

Hi @karolyi,

We were working on publishing our releases to PyPI now that our pipeline has been fixed. This temporarily caused some releases on GitHub to appear out of order—apologies for the confusion. This should be resolved now.

I also wanted to let you know that our latest release includes the fix in #345!

Kind regards,
Djoyke
Adyen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants