[ECP-9476]Updating Paybylink description for Magento Orders #2810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
had a problem deploying
to
internal
GitHub Actions
Failure
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
had a problem deploying
to
internal
GitHub Actions
Failure
candemiralp
approved these changes
Nov 22, 2024
candemiralp
reviewed
Nov 25, 2024
| $order->getStore()->getGroup()->getName() | ||
| ); | ||
|
|
||
| $request['body']['description'] = 'Order ' . $order->getIncrementId() . ' from ' . $order->getStore()->getGroup()->getName(); |
There was a problem hiding this comment.
We will lose the localisation capabilities after removing the phrase and merchants will not be able to add translation. Do we know why this is an issue now especially after migrating to model based library?
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
had a problem deploying
to
internal
GitHub Actions
Failure
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves an issue where the description in the pay by link created from Magento admin order is diplaying {} instead of the usual value that used to have
Order XXXXXX00 from Main Website Storeon the payment screen for the customer facing.Tested scenarios
Fixes