Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Candidate #866

Closed
wants to merge 7 commits into from
Closed

Release Candidate #866

wants to merge 7 commits into from

Conversation

AlexandrosMor
Copy link
Contributor

@AlexandrosMor AlexandrosMor commented Aug 18, 2023 •
edited
Loading

Description
This PR upgrades:

  1. ManagementService-v3
  2. ManagmentNotificationService-v3
  3. TransferService-v4
  4. BalancePlatformTransferNotification-v4

@AlexandrosMor AlexandrosMor marked this pull request as ready for review August 18, 2023 13:08
@AlexandrosMor AlexandrosMor requested a review from a team as a code owner August 18, 2023 13:08
michaelpaul
michaelpaul requested changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@michaelpaul michaelpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP

Aleffio
Aleffio reviewed Aug 23, 2023
View reviewed changes
Copy link
Contributor

@Aleffio Aleffio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor, let's also update the version of the hateoas links in the mocks

adyen-dotnet-api-library/Adyen.Test/mocks/management/list-merchant-accounts.json

Line 4 in 1b6242d

"href": "https://management-test.adyen.com/v1/companies/YOUR_COMPANY_ACCOUNT/merchants?pageNumber=1&pageSize=10"

@AlexandrosMor
Copy link
Contributor Author

@Aleffio check again ?

Aleffio
Aleffio previously approved these changes Aug 23, 2023
View reviewed changes
michaelpaul
michaelpaul requested changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@michaelpaul michaelpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP

@AlexandrosMor AlexandrosMor changed the title update makefile and readme to upgrade Transfers and Management API Release Candidate Oct 13, 2023
Aleffio
Aleffio reviewed Oct 20, 2023
View reviewed changes
Makefile Outdated
LegalEntityManagement: spec=LegalEntityService-v3
PlatformsAccount: spec=AccountService-v6
PlatformsFund: spec=FundService-v6
PlatformsNotificationConfiguration: spec=NotificationConfigurationService-v6
PlatformsHostedOnboardingPage: spec=HopService-v6
Transfers: spec=TransferService-v3
Transfers: spec=TransferService-v4
ManagmentNotificationService: spec=ManagementNotificationService-v3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ManagmentNotificationService: spec=ManagementNotificationService-v3
ManagementNotificationService: spec=ManagementNotificationService-v3

Makefile Outdated Show resolved Hide resolved
@jillingk jillingk closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleffio Aleffio Aleffio left review comments

@michaelpaul michaelpaul michaelpaul requested changes

Assignees
No one assigned
Labels
Breaking change Don't merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexandrosMor @michaelpaul @Aleffio @jillingk