Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated readme with disclaimer on Enum values #1070

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Conversation

DjoykeAbyah
Copy link
Member

Description

This PR updates the README to include a disclaimer regarding the potential for enum values to change in future releases. This change ensures that users are aware that they should not rely on the enum values being static, and should handle them dynamically or with caution in their implementations.

  • Added a new section in the README under ## Disclaimer on Enum Values.
  • Explained that enum values may be modified, added, or removed in future releases.

@DjoykeAbyah DjoykeAbyah requested review from a team as code owners October 8, 2024 15:15
Copy link

sonarcloud bot commented Oct 8, 2024

@Kwok-he-Chu
Copy link
Contributor

Kwok-he-Chu commented Oct 8, 2024

I've found several cases (but not limited to these* only), this will become a problem if the underlying integer value is stored instead of the respective string-value.

I have opened an issue/discussion for now. As of currently, adding one (alphabetical-ordered) enum in the OpenApi specifications results in an immediate breaking change when generating the library

@DjoykeAbyah DjoykeAbyah merged commit 7050746 into main Oct 8, 2024
6 checks passed
@DjoykeAbyah DjoykeAbyah deleted the update-readme branch October 8, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants