Порт Р.П.А. с Сирены #729
Merged
Порт Р.П.А. с Сирены #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Добавлен Р.П.А. - ручной поисковик аномалий (by That_is_not_Sloni122). Пинпоинтер, что указывает на все сущности с компонентом `Anomaly`. Также он добавлен в шкаф научрука. А ещё добавлена триторская цель на него. *P.S. сборка не проверялась. Тесты не проводились.* Co-authored-by: kingmonkeyx <kingmonkeyx@email> Reviewed-on: https://codeberg.org/NekoDar/SS14-Sirena/pulls/40 Co-authored-by: kingmonkeyx <[email protected]> Co-committed-by: kingmonkeyx <[email protected]>
…pace_station into anomaly_pinpointer
|
я не думаю, что это хорошая идея... |
Schrodinger71
requested changes
May 24, 2024
There was a problem hiding this comment.
Ошибки в билдтестах. Ещё бы для баланса этому устройству нужно бы сделать потребление энергии от батарейки
Failed NoCargoBountyArbitrageTest [4 s]
Stack Trace:
1) at Content.IntegrationTests.Pair.TestPair.OnDirtyDispose() in /home/runner/work/space_station/space_station/Content.IntegrationTests/Pair/TestPair.Recycle.cs:line 32
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
at Content.IntegrationTests.Pair.TestPair.OnDirtyDispose()
at Content.IntegrationTests.Pair.TestPair.DisposeAsync() in /home/runner/work/space_station/space_station/Content.IntegrationTests/Pair/TestPair.Recycle.cs:line 102
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
at Content.IntegrationTests.Pair.TestPair.DisposeAsync()
at Content.IntegrationTests.Tests.CargoTest.NoCargoBountyArbitrageTest() in /home/runner/work/space_station/space_station/Content.IntegrationTests/Tests/CargoTest.cs:line 93
at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.ExecutionContextCallback(Object s)
Failed NoStaticPriceAndStackPrice [42 ms]
Error Message:
Assert.That(delta, Is.EqualTo(targetDelta))
Expected: 1
But was: 0
Stack Trace:
at Content.IntegrationTests.Pair.TestPair.SyncTicks(Int32 targetDelta) in /home/runner/work/space_station/space_station/Content.IntegrationTests/Pair/TestPair.Timing.cs:line 60
at Content.IntegrationTests.PoolManager.GetServerClientPair(PoolSettings poolSettings) in /home/runner/work/space_station/space_station/Content.IntegrationTests/PoolManager.cs:line 248
at Content.IntegrationTests.PoolManager.GetServerClientPair(PoolSettings poolSettings) in /home/runner/work/space_station/space_station/Content.IntegrationTests/PoolManager.cs:line 266
at Content.IntegrationTests.PoolManager.GetServerClient(PoolSettings poolSettings) in /home/runner/work/space_station/space_station/Content.IntegrationTests/PoolManager.cs:line 192
at Content.IntegrationTests.Tests.CargoTest.NoStaticPriceAndStackPrice() in /home/runner/work/space_station/space_station/Content.IntegrationTests/Tests/CargoTest.cs:line 99
at NUnit.Framework.Internal.TaskAwaitAdapter.GenericAdapter`1.BlockUntilCompleted()
at NUnit.Framework.Internal.MessagePumpStrategy.NoMessagePumpStrategy.WaitForCompletion(AwaitAdapter awaiter)
at NUnit.Framework.Internal.AsyncToSyncAdapter.Await[TResult](Func`1 invoke)
at NUnit.Framework.Internal.AsyncToSyncAdapter.Await(Func`1 invoke)
at NUnit.Framework.Internal.Commands.TestMethodCommand.RunTestMethod(TestExecutionContext context)
at NUnit.Framework.Internal.Commands.TestMethodCommand.Execute(TestExecutionContext context)
at NUnit.Framework.Internal.Execution.SimpleWorkItem.<>c__DisplayClass3_0.<PerformWork>b__0()
at NUnit.Framework.Internal.ContextUtils.<>c__DisplayClass1_0`1.<DoIsolated>b__0(Object _)
1) at Content.IntegrationTests.Pair.TestPair.SyncTicks(Int32 targetDelta) in /home/runner/work/space_station/space_station/Content.IntegrationTests/Pair/TestPair.Timing.cs:line 60
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
at Content.IntegrationTests.Pair.TestPair.SyncTicks(Int32 targetDelta)
at Content.IntegrationTests.PoolManager.GetServerClientPair(PoolSettings poolSettings) in /home/runner/work/space_station/space_station/Content.IntegrationTests/PoolManager.cs:line [248](https://github.com/xtray85/space_station/actions/runs/9217012454/job/25358304114?pr=729#step:10:249)
at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.ExecutionContextCallback(Object s)
знал бы я как их фиксить ещё и что их вызывает |
|
а ну всё, вроде пропали ошибки |
хорошо, тогда аппрувни пожалуйста |
|
описание лучше поменять на что-то благоприятное |
Schrodinger71
approved these changes
May 26, 2024
Schrodinger71
merged commit 967b996
into
AdventureTimeSS14:master
12 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание PR
Продолжаем портировать годноту с Сирены. На этот раз настала очередь Р.П.А. - пинпоинтера аномалий, который является хайриском Научрука. Крайне полезная вещь, не теряйте.
Медиа
Проверки
Изменения
🆑 Username228