Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore newly added (unsupported) onnx test cases #193

Merged

Conversation

Swopper050
Copy link
Collaborator

Closes #192

@Swopper050 Swopper050 requested a review from wipsel January 29, 2024 09:47
@Swopper050 Swopper050 self-assigned this Jan 29, 2024
@Swopper050 Swopper050 added this to the GONNX v1.1.0 milestone Jan 29, 2024
@Swopper050 Swopper050 changed the title Ignore newly added (unsupported) onnx test cases (#192) Ignore newly added (unsupported) onnx test cases #192 Jan 29, 2024
@Swopper050 Swopper050 changed the title Ignore newly added (unsupported) onnx test cases #192 Ignore newly added (unsupported) onnx test cases Jan 29, 2024
@wipsel
Copy link
Collaborator

wipsel commented Jan 29, 2024

LGTM

@wipsel
Copy link
Collaborator

wipsel commented Jan 29, 2024

Maybe we should pin the verion of the onnx repo so that we don't have this problem in future?

wipsel
wipsel previously approved these changes Jan 29, 2024
Copy link
Collaborator

@wipsel wipsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

akkoo

@Swopper050 Swopper050 merged commit d18cfab into AdvancedClimateSystems:develop Jan 29, 2024
4 checks passed
@Swopper050 Swopper050 removed this from the GONNX v1.1.0 milestone Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore newly added GONNX tests
2 participants