Fix lint errors

Makefile

@@ -44,7 +44,7 @@ test_ci: ## Run tests using normal test runner for ci output.
 
 test_data:  ## Creates test data from the ONNX test module.
 	rm -R ./test_data; mkdir ./test_data; touch ./test_data/
-	git clone --depth 1 --branch v1.15.0 https://github.com/onnx/onnx.git temp_onnx
+	git clone --depth 1 --branch v1.17.0 https://github.com/onnx/onnx.git temp_onnx
 	cp -r temp_onnx/onnx/backend/test/data/node/* ./test_data
 	rm -Rf temp_onnx
 

ops/constant/constant_1.go

@@ -26,7 +26,7 @@ func (c *Constant1) Init(n *onnx.NodeProto) error {
 	attr := attributes[0]
 
 	switch attr.GetName() {
-	case "value":
+	case value:
 		t, err := onnx.TensorFromProto(attr.GetT())
 		if err != nil {
 			return err

ops/constant/constant_11.go

@@ -27,9 +27,9 @@ func (c *Constant11) Init(n *onnx.NodeProto) error {
 	attr := attributes[0]
 
 	switch attr.GetName() {
-	case "sparse_value":
+	case sparseValue:
 		return ops.ErrUnsupportedAttribute(attr.GetName(), c)
-	case "value":
+	case value:
 		t, err := onnx.TensorFromProto(attr.GetT())
 		if err != nil {
 			return err

ops/constant/constant_12.go

@@ -27,23 +27,23 @@ func (c *Constant12) Init(n *onnx.NodeProto) error {
 	attr := attributes[0]
 
 	switch attr.GetName() {
-	case "sparse_value", "value_string", "value_strings":
+	case sparseValue, valueString, valueStrings:
 		return ops.ErrUnsupportedAttribute(attr.GetName(), c)
-	case "value":
+	case value:
 		t, err := onnx.TensorFromProto(attr.GetT())
 		if err != nil {
 			return err
 		}
 
 		c.value = t
-	case "value_float":
+	case valueFloat:
 		c.value = tensor.New(tensor.FromScalar(attr.GetF()))
-	case "value_floats":
+	case valueFloats:
 		floats := attr.GetFloats()
 		c.value = tensor.New(tensor.WithShape(len(floats)), tensor.WithBacking(floats))
-	case "value_int":
+	case valueInt:
 		c.value = tensor.New(tensor.FromScalar(attr.GetI()))
-	case "value_ints":
+	case valueInts:
 		ints := attr.GetInts()
 		c.value = tensor.New(tensor.WithShape(len(ints)), tensor.WithBacking(ints))
 	default:

ops/constant/constant_13.go

@@ -27,23 +27,23 @@ func (c *Constant13) Init(n *onnx.NodeProto) error {
 	attr := attributes[0]
 
 	switch attr.GetName() {
-	case "sparse_value", "value_string", "value_strings":
+	case sparseValue, valueString, valueStrings:
 		return ops.ErrUnsupportedAttribute(attr.GetName(), c)
-	case "value":
+	case value:
 		t, err := onnx.TensorFromProto(attr.GetT())
 		if err != nil {
 			return err
 		}
 
 		c.value = t
-	case "value_float":
+	case valueFloat:
 		c.value = tensor.New(tensor.FromScalar(attr.GetF()))
-	case "value_floats":
+	case valueFloats:
 		floats := attr.GetFloats()
 		c.value = tensor.New(tensor.WithShape(len(floats)), tensor.WithBacking(floats))
-	case "value_int":
+	case valueInt:
 		c.value = tensor.New(tensor.FromScalar(attr.GetI()))
-	case "value_ints":
+	case valueInts:
 		ints := attr.GetInts()
 		c.value = tensor.New(tensor.WithShape(len(ints)), tensor.WithBacking(ints))
 	default:

ops/constant/constant_9.go

@@ -26,7 +26,7 @@ func (c *Constant9) Init(n *onnx.NodeProto) error {
 	attr := attributes[0]
 
 	switch attr.GetName() {
-	case "value":
+	case value:
 		t, err := onnx.TensorFromProto(attr.GetT())
 		if err != nil {
 			return err

ops/flatten/flatten_1.go

@@ -27,7 +27,7 @@ func newFlatten1() ops.Operator {
 func (f *Flatten1) Init(n *onnx.NodeProto) error {
 	for _, attr := range n.GetAttribute() {
 		switch attr.GetName() {
-		case "axis":
+		case axis:
 			f.axis = int(attr.GetI())
 		default:
 			return ops.ErrInvalidAttribute(attr.GetName(), f)
@@ -40,6 +40,7 @@ func (f *Flatten1) Init(n *onnx.NodeProto) error {
 // Apply applies the flatten operator.
 func (f *Flatten1) Apply(inputs []tensor.Tensor) ([]tensor.Tensor, error) {
 	inputShape := inputs[0].Shape()
+
 	out, ok := inputs[0].Clone().(tensor.Tensor)
 	if !ok {
 		return nil, ops.ErrTypeAssert("tensor.Tensor", inputs[0].Clone())

ops/flatten/flatten_11.go

@@ -27,7 +27,7 @@ func newFlatten11() ops.Operator {
 func (f *Flatten11) Init(n *onnx.NodeProto) error {
 	for _, attr := range n.GetAttribute() {
 		switch attr.GetName() {
-		case "axis":
+		case axis:
 			f.axis = int(attr.GetI())
 		default:
 			return ops.ErrInvalidAttribute(attr.GetName(), f)

ops/flatten/flatten_13.go

@@ -27,7 +27,7 @@ func newFlatten13() ops.Operator {
 func (f *Flatten13) Init(n *onnx.NodeProto) error {
 	for _, attr := range n.GetAttribute() {
 		switch attr.GetName() {
-		case "axis":
+		case axis:
 			f.axis = int(attr.GetI())
 		default:
 			return ops.ErrInvalidAttribute(attr.GetName(), f)

ops/flatten/flatten_9.go

@@ -27,7 +27,7 @@ func newFlatten9() ops.Operator {
 func (f *Flatten9) Init(n *onnx.NodeProto) error {
 	for _, attr := range n.GetAttribute() {
 		switch attr.GetName() {
-		case "axis":
+		case axis:
 			f.axis = int(attr.GetI())
 		default:
 			return ops.ErrInvalidAttribute(attr.GetName(), f)
@@ -40,6 +40,7 @@ func (f *Flatten9) Init(n *onnx.NodeProto) error {
 // Apply applies the flatten operator.
 func (f *Flatten9) Apply(inputs []tensor.Tensor) ([]tensor.Tensor, error) {
 	inputShape := inputs[0].Shape()
+
 	out, ok := inputs[0].Clone().(tensor.Tensor)
 	if !ok {
 		return nil, ops.ErrTypeAssert("tensor.Tensor", inputs[0].Clone())

ops/gather/gather_1.go

@@ -30,7 +30,7 @@ func (g *Gather1) Init(n *onnx.NodeProto) error {
 	if len(attributes) == 1 {
 		attr := attributes[0]
 
-		if attr.GetName() == "axis" {
+		if attr.GetName() == axis {
 			g.axis = int(attr.GetI())
 		} else {
 			return ops.ErrInvalidAttribute(attr.GetName(), g)

ops/gather/gather_11.go

@@ -30,7 +30,7 @@ func (g *Gather11) Init(n *onnx.NodeProto) error {
 	if len(attributes) == 1 {
 		attr := attributes[0]
 
-		if attr.GetName() == "axis" {
+		if attr.GetName() == axis {
 			g.axis = int(attr.GetI())
 		} else {
 			return ops.ErrInvalidAttribute(attr.GetName(), g)

ops/gather/gather_13.go

@@ -30,7 +30,7 @@ func (g *Gather13) Init(n *onnx.NodeProto) error {
 	if len(attributes) == 1 {
 		attr := attributes[0]
 
-		if attr.GetName() == "axis" {
+		if attr.GetName() == axis {
 			g.axis = int(attr.GetI())
 		} else {
 			return ops.ErrInvalidAttribute(attr.GetName(), g)

ops/gemm/gemm_11.go

@@ -33,13 +33,13 @@ func newGemm11() ops.Operator {
 func (g *Gemm11) Init(n *onnx.NodeProto) error {
 	for _, attr := range n.GetAttribute() {
 		switch attr.GetName() {
-		case "alpha":
+		case alpha:
 			g.alpha = attr.GetF()
-		case "beta":
+		case beta:
 			g.beta = attr.GetF()
-		case "transA":
+		case transA:
 			g.transA = ops.Int64ToBool(attr.GetI())
-		case "transB":
+		case transB:
 			g.transB = ops.Int64ToBool(attr.GetI())
 		default:
 			return ops.ErrInvalidAttribute(attr.GetName(), g)

ops/gemm/gemm_13.go

@@ -33,13 +33,13 @@ func newGemm13() ops.Operator {
 func (g *Gemm13) Init(n *onnx.NodeProto) error {
 	for _, attr := range n.GetAttribute() {
 		switch attr.GetName() {
-		case "alpha":
+		case alpha:
 			g.alpha = attr.GetF()
-		case "beta":
+		case beta:
 			g.beta = attr.GetF()
-		case "transA":
+		case transA:
 			g.transA = ops.Int64ToBool(attr.GetI())
-		case "transB":
+		case transB:
 			g.transB = ops.Int64ToBool(attr.GetI())
 		default:
 			return ops.ErrInvalidAttribute(attr.GetName(), g)

ops/gemm/gemm_7.go

@@ -33,13 +33,13 @@ func newGemm7() ops.Operator {
 func (g *Gemm7) Init(n *onnx.NodeProto) error {
 	for _, attr := range n.GetAttribute() {
 		switch attr.GetName() {
-		case "alpha":
+		case alpha:
 			g.alpha = attr.GetF()
-		case "beta":
+		case beta:
 			g.beta = attr.GetF()
-		case "transA":
+		case transA:
 			g.transA = ops.Int64ToBool(attr.GetI())
-		case "transB":
+		case transB:
 			g.transB = ops.Int64ToBool(attr.GetI())
 		default:
 			return ops.ErrInvalidAttribute(attr.GetName(), g)

ops/gemm/gemm_9.go

@@ -33,13 +33,13 @@ func newGemm9() ops.Operator {
 func (g *Gemm9) Init(n *onnx.NodeProto) error {
 	for _, attr := range n.GetAttribute() {
 		switch attr.GetName() {
-		case "alpha":
+		case alpha:
 			g.alpha = attr.GetF()
-		case "beta":
+		case beta:
 			g.beta = attr.GetF()
-		case "transA":
+		case transA:
 			g.transA = ops.Int64ToBool(attr.GetI())
-		case "transB":
+		case transB:
 			g.transB = ops.Int64ToBool(attr.GetI())
 		default:
 			return ops.ErrInvalidAttribute(attr.GetName(), g)

ops/matmul/matmul_1.go

@@ -134,7 +134,7 @@ func (m *MatMul1) GetInputTypeConstraints() [][]tensor.Dtype {
 
 // String implements the stringer interface, and can be used to format errors or messages.
 func (m *MatMul1) String() string {
-	return "matmul13 operator"
+	return "matmul1 operator"
 }
 
 // broadcastTensors broadcasts both tensors for the matmul operator. It is almost identical

ops/matmul/matmul_9.go

@@ -134,7 +134,7 @@ func (m *MatMul9) GetInputTypeConstraints() [][]tensor.Dtype {
 
 // String implements the stringer interface, and can be used to format errors or messages.
 func (m *MatMul9) String() string {
-	return "matmul13 operator"
+	return "matmul9 operator"
 }
 
 // broadcastTensors broadcasts both tensors for the matmul operator. It is almost identical

ops/reducemax/reduce_max_1.go

@@ -34,14 +34,14 @@ func (r *ReduceMax1) Init(n *onnx.NodeProto) error {
 
 	for _, attr := range attributes {
 		switch attr.GetName() {
-		case "axes":
+		case axes:
 			axes, err := ops.AnyToIntSlice(attr.GetInts())
 			if err != nil {
 				return err
 			}
 
 			r.axes = axes
-		case "keepdims":
+		case keepDims:
 			r.keepDims = attr.GetI() == 1
 		default:
 			return ops.ErrInvalidAttribute(attr.GetName(), r)

ops/reducemax/reduce_max_11.go

@@ -34,14 +34,14 @@ func (r *ReduceMax11) Init(n *onnx.NodeProto) error {
 
 	for _, attr := range attributes {
 		switch attr.GetName() {
-		case "axes":
+		case axes:
 			axes, err := ops.AnyToIntSlice(attr.GetInts())
 			if err != nil {
 				return err
 			}
 
 			r.axes = axes
-		case "keepdims":
+		case keepDims:
 			r.keepDims = attr.GetI() == 1
 		default:
 			return ops.ErrInvalidAttribute(attr.GetName(), r)

ops/reducemax/reduce_max_12.go

@@ -34,14 +34,14 @@ func (r *ReduceMax12) Init(n *onnx.NodeProto) error {
 
 	for _, attr := range attributes {
 		switch attr.GetName() {
-		case "axes":
+		case axes:
 			axes, err := ops.AnyToIntSlice(attr.GetInts())
 			if err != nil {
 				return err
 			}
 
 			r.axes = axes
-		case "keepdims":
+		case keepDims:
 			r.keepDims = attr.GetI() == 1
 		default:
 			return ops.ErrInvalidAttribute(attr.GetName(), r)

ops/reducemax/reduce_max_13.go

@@ -34,14 +34,14 @@ func (r *ReduceMax13) Init(n *onnx.NodeProto) error {
 
 	for _, attr := range attributes {
 		switch attr.GetName() {
-		case "axes":
+		case axes:
 			axes, err := ops.AnyToIntSlice(attr.GetInts())
 			if err != nil {
 				return err
 			}
 
 			r.axes = axes
-		case "keepdims":
+		case keepDims:
 			r.keepDims = attr.GetI() == 1
 		default:
 			return ops.ErrInvalidAttribute(attr.GetName(), r)

ops/reducemin/reduce_min_1.go

@@ -34,14 +34,14 @@ func (r *ReduceMin1) Init(n *onnx.NodeProto) error {
 
 	for _, attr := range attributes {
 		switch attr.GetName() {
-		case "axes":
+		case axes:
 			axes, err := ops.AnyToIntSlice(attr.GetInts())
 			if err != nil {
 				return err
 			}
 
 			r.axes = axes
-		case "keepdims":
+		case keepDims:
 			r.keepDims = attr.GetI() == 1
 		default:
 			return ops.ErrInvalidAttribute(attr.GetName(), r)

ops/reducemin/reduce_min_11.go

@@ -34,14 +34,14 @@ func (r *ReduceMin11) Init(n *onnx.NodeProto) error {
 
 	for _, attr := range attributes {
 		switch attr.GetName() {
-		case "axes":
+		case axes:
 			axes, err := ops.AnyToIntSlice(attr.GetInts())
 			if err != nil {
 				return err
 			}
 
 			r.axes = axes
-		case "keepdims":
+		case keepDims:
 			r.keepDims = attr.GetI() == 1
 		default:
 			return ops.ErrInvalidAttribute(attr.GetName(), r)

ops/reducemin/reduce_min_12.go

@@ -34,14 +34,14 @@ func (r *ReduceMin12) Init(n *onnx.NodeProto) error {
 
 	for _, attr := range attributes {
 		switch attr.GetName() {
-		case "axes":
+		case axes:
 			axes, err := ops.AnyToIntSlice(attr.GetInts())
 			if err != nil {
 				return err
 			}
 
 			r.axes = axes
-		case "keepdims":
+		case keepDims:
 			r.keepDims = attr.GetI() == 1
 		default:
 			return ops.ErrInvalidAttribute(attr.GetName(), r)