Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AdGuard Quick Fixes filter #187308

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Added AdGuard Quick Fixes filter #187308

merged 3 commits into from
Aug 27, 2024

Conversation

Alex-302
Copy link
Member

No description provided.

@Alex-302 Alex-302 requested review from ameshkov, vozersky and a team August 27, 2024 09:26
Copy link
Contributor

@BlazDT BlazDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When adding rules there, we should also note the time of addition (due to 14 days). Else you have to check GitHub history when it was added.

Probably should be added as comment.

@Alex-302
Copy link
Member Author

Alex-302 commented Aug 27, 2024

Vscode shows this info (maybe with GitLens extension)
image

Or we can add a date.

@Alex-302 Alex-302 merged commit 1a6fc21 into master Aug 27, 2024
4 checks passed

### AdGuard Quick Fixes filter

- Purpose: This filter serves as a quick-response solution, ensuring that AdGuard Mv3 extension
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

вот тут может сделаем как ниже?

This file serves as a quick-response solution to ensure that users of the AdGuard Mv3 extension experience minimal disruption while waiting for the extension to update along with the static filters.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Да норм вроде.

! - Limited lifetime: All rules added to this file are temporary will be removed 14 days after they are added.
! - Flexibility: Rules can be added to resolve critical issues quickly, with no restrictions based on the source of the problem.
!
! Rules must be added with the date of addition for ease of future deletion.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

вот так бы сделала
To make it easier to delete rules in the future, they must be added with their date of addition.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ок, заменил.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants