All dev changes from GreenSurvivors #383
Conversation
Offhand can now be placed without errors
Adding new 1.16 materials and prevent outdating through new materials.
Fixing not visible tool-points
- Change RegionDisplay to Barrier and imporved performance issues, when many and big regions were displayed
Action "Take Item" had another name in the gui -> "Give Item"
Several translation string were missed or were not correctly used.
- TakeFlagTrigger wasn't triggered - Only Oak-Signs worked as Flags - Broadcasts wasn't working - CTF-Broadcasts are now a seperate option - Flag Home-Returns were announced, even though broadcasts were disabled
Severall Bugfixes for gui and game elements; Adding some new Game Elements like, potionFriendlyFire and gameTickTriggers.
* Fixed reset of Blocks in Minigames.
RegenRegions can now be splittet into several smaller regions. This allows to be more flexible: Big Regions with eg. 4 million blocks are crashing the server. If only small fitting regions are set, there is no need for 4 million blocks to regen. Also a block limit is implemented to ensure that a crash is not going to happen. This limit can be changed within the minigames config file and is default set to 300k.
Co-authored-by: joshi1999 <[email protected]>
In rare occasions a user can be a spectator as well as a player (however that happened)
This may still have a desync problem with the client where menu items are invisible. This, however is a client problem and even player.updateInventory will not help, as it get called anyway if the event gets cancelled.
Feuer fixes
RegenRecorder etc. are working now just fine
Adding recorder deactivation option Adding missing Team Colors
|
I noticed a few Codacy issues that I probably agree with, so I might also add a few minor commits to make it happy. |
|
Looks good to me. |
When you say all 3 do you mean the codacy changes? Or something else? Sorry I'm not sure I understood that. |
|
yeah all 3 codacy changes |
Oh no problem, happy to take your fix (I didn't see it) instead, I assume they're very similar to what I did? Or I can just merge this now and just handle the merge conflict later when I pull in your fix. |
|
Decided to just merge this and we'll just see how we go in the future and we'll do our testing 🙂 Thank you again for all your fixes, improvements and changes! ❤️ |
As per the discussion in #381, we decided it would be best for us to just merge in the
devbranch changes from GreenSurvivors.Since we no longer do actual releases (or at least, we haven't in a very long time) and Minigames is only available for now as dev builds, we figured it's fine to pull in these dev changes so we can do our own testing/validation. I had planned to just cherry-pick fixes but there were so many good fixes and improvements it wasn't worth it 😉
If anyone has troubles with these changes, they can revert to the previous build and report the issues to us.
@FireInstall @joshi1999: Just wanted to double check there's nothing in here that you think we should avoid? Also, we've included the changes that add your team to the
plugin.ymlauthors, you deserve it! Thank you! ❤️