Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct syntax to reference a github repository. #213

Closed
wants to merge 25 commits into from

Conversation

cyril-sf
Copy link
Contributor

@cyril-sf cyril-sf commented Oct 3, 2014

The previous syntax was creating an error in my project using grunt-bower-task.

grunt-bower copying
Fatal error: ENOENT, no such file or directory 'vendor/antiscroll'

andrewfan and others added 22 commits June 26, 2014 21:13
revert dist files

remove idea files

add dist files
Hide fixed columns table when numFixedColumns is 0
This upgrades grunt-bower-task's version of bower, which fixes the
problem with the tmp package.
Make selection contain the contents of rows, rather than the row objects
themselves, and make a new Ember.Set for each EmberTableComponent

Closes #192
* Add community examples page
* Clean up dependencies list
* Remove some unhelpful descriptions
* Reorganize pages
* Add migration guides page
* Fix sidebar covering footer
* Updates the gh_pages folder so it can stand alone
* Use release-it to push to gh-pages on every release

Other small tweaks:

* Use grunt-release-it as a wrapper for release-it
* Move bower dependencies to vendor/ folder
* Only code change is refactoring src/row.coffee to its own file
* Remove old comment style which doesn't have any content
* Organize inputs/outputs into separate blocks
* Once this is merged, I will copy the wording to the docs pages
  * Ideally we'd add a generate-docs command to grunt, but this is too
    hard to justify doing right now.
* Copy code documentation to docs pages
* Add a few previously undocumented options
* Configure <code> tag to display better
@cyril-sf cyril-sf force-pushed the cyril-sf/fix-bower branch from e87075d to 2380dc8 Compare October 3, 2014 21:06
@azirbel
Copy link
Contributor

azirbel commented Oct 6, 2014

Is there a reason to change to daviesgeek's version of antiscroll over LearnBoost's version? Maybe for daviesgeek/antiscroll@9b67eb3?

@cyril-sf
Copy link
Contributor Author

cyril-sf commented Oct 6, 2014

Yes, the project doesn't seem to be really maintainted and lacks of a bower.json file. See Automattic/antiscroll#80

@azirbel
Copy link
Contributor

azirbel commented Oct 20, 2014

Ok, fine with me. Thanks!

@azirbel
Copy link
Contributor

azirbel commented Oct 20, 2014

Actually, could you rebase on master? Then I'll merge.

The previous syntax was creating an error in my project using
grunt-bower-task.

grunt-bower copying
Fatal error: ENOENT, no such file or directory 'vendor/antiscroll'
@cyril-sf
Copy link
Contributor Author

Closing this one in favor of #220 as it's targeting a branch and not master.

@cyril-sf cyril-sf closed this Oct 20, 2014
@cyril-sf cyril-sf deleted the cyril-sf/fix-bower branch October 20, 2014 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants