Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add embroider-safe, -optimized scenarios #54

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

bantic
Copy link
Contributor

@bantic bantic commented Jan 3, 2025

Builds on #52. This is ready for review, but #52 should be reviewed/merged first.
The relative diff is very modest: bantic/webcore-3122-fix-ci-ember-4...bantic/webcore-3124-embroider

This follows https://github.com/embroider-build/embroider/blob/5fd49b50dd82bf7ceb6adeefa12efc2b85f92cd2/ADDON-AUTHOR-GUIDE.md#support-level-embroider-safe to add embroider scenarios to CI.

@bantic bantic changed the title [draft] CI: Add embroider-safe scenario [draft] CI: Add embroider scenarios Jan 3, 2025
@bantic bantic force-pushed the bantic/webcore-3124-embroider branch 2 times, most recently from 252eb37 to a1c9adb Compare January 6, 2025 09:26
@bantic bantic changed the title [draft] CI: Add embroider scenarios CI: Add embroider-safe, -optimized scenarios Jan 6, 2025
@bantic bantic marked this pull request as ready for review January 6, 2025 09:28
@bantic bantic requested review from a team January 6, 2025 09:28
@bantic bantic force-pushed the bantic/webcore-3124-embroider branch from a1c9adb to addf50a Compare January 6, 2025 14:37
@bantic bantic merged commit 5a67faa into master Jan 6, 2025
9 checks passed
@bantic bantic deleted the bantic/webcore-3124-embroider branch January 6, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants